secondlife/viewer#2349: Avatar/animesh rendering correctness pass #2364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmic-linden
commented
Aug 20, 2024
cosmic-linden
commented
Aug 20, 2024
cosmic-linden
changed the title
cosmic-linden
changed the title
cosmic-linden
commented
Aug 21, 2024
| @@ -688,6 +671,81 @@ bool LLRenderPass::uploadMatrixPalette(LLVOAvatar* avatar, LLMeshSkinInfo* skinI | |||
| return true; | |||
| } | |||
|
|
|||
| // Returns true if rendering should proceed | |||
| //static | |||
| bool LLRenderPass::uploadMatrixPalette(LLVOAvatar* avatar, LLMeshSkinInfo* skinInfo, const LLVOAvatar*& lastAvatar, U64& lastMeshId, bool& skipLastSkin) | |||
There was a problem hiding this comment.
Inspection of LLDrawPoolMaterials indicated that there are several important things to check when drawing a rigged mesh:
- Is the avatar null? If so, don't render.
- Note: Some cases of null avatar are more suspicious than others. Some may be bugs. I previously added
llassert(avatar)here for a bit to catch some bugs, but I'm not convinced all cases of null avatar are bugs.
- Note: Some cases of null avatar are more suspicious than others. Some may be bugs. I previously added
- Is the matrix palette not defined? If so, don't render.
- During alpha draw passes, shaders are interleaved, so don't assume the skinning is up-to-date if the shader changes
cosmic-linden
commented
Aug 21, 2024
| count, | ||
| false, | ||
| (GLfloat*)&(mpc.mGLMp[0])); | ||
| continue; |
There was a problem hiding this comment.
This is now a continue, but was previously a return. The return appeared to not be correct, as it would interfere with the rendering of other objects in the draw pool.
RunitaiLinden
approved these changes
Aug 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.