-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce LLUIColorTable debug-settings-alike floater and fix various color system bugs #2190
Conversation
RyeMutt
commented
Aug 5, 2024
•
edited
Loading
edited
- Introduce a floater that can access LLUIColortable and update/reset color settings
- Fix chat colors not dynamically updating when changed in preferences
- Fix script editors not dynamically updating when changed in script editor preferences
- Introduce alpha parameter to LLStyle to allow setting text UI color alpha at runtime without breaking reference to color table
- Cache and optimize various color finds during draw
b940bc5
to
409b9ee
Compare
@@ -152,6 +152,7 @@ void LLFloaterIMNearbyChatToastPanel::addMessage(LLSD& notification) | |||
{ | |||
LLStyle::Params style_params; | |||
style_params.color(textColor); | |||
style_params.alpha(textAlpha); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is undoubtfully a good change, but perhaps this should be in a different review? Adding alpha and background to text is a bit out of scope for a color debug floater.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was to replicate the previous behavior in https://github.com/secondlife/viewer/pull/2190/files#diff-b22849a085421bd71afc6b02046ac27f258e5c4ebc9c524b541653ab44174229L104 but without breaking the color reference and thus dynamic updates. I could try to separate out the bug fixes from the new floaterif that would be easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine to keep it together if they are troublesome to separate. But please, separately note those alpha changes in review's header, just in case.
A lot of macOS build errors related to streams, like:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build looks fine now.
Thank you for the contribution!