Fix failure to join or detach threads causing rare shutdown termination #2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akleshchev
approved these changes
Jul 22, 2024
nat-goodspeed
requested changes
Aug 1, 2024
| @@ -269,6 +269,7 @@ void LLThread::shutdown() | |||
| mStatus = STOPPED; | |||
| return; | |||
| } | |||
| delete mThreadp; | |||
There was a problem hiding this comment.
I'd rather see mThreadp be a std::unique_ptr<std::thread>, with a reset() call here and in start().
There was a problem hiding this comment.
Thank you, that's probably outside of a 'contribution' work, I will do an issue for that later.
| @@ -299,6 +300,7 @@ void LLThread::start() | |||
| { | |||
| mThreadp = new std::thread(std::bind(&LLThread::threadRun, this)); | |||
| mNativeHandle = mThreadp->native_handle(); | |||
| mThreadp->detach(); | |||
There was a problem hiding this comment.
Given that we have explicit logic to wait for thread termination, but time out and forcibly kill the thread, this makes sense, yes. In effect we manually "try to join()."
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a behavior where LLThreads were never detached or joined and could result in a crash on shutdown in rare instances .