Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert LLLuaFloater "idle" events in favor of Lua timers.Timer(). #1811

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

nat-goodspeed
Copy link
Collaborator

No description provided.

Copy link
Contributor

@maxim-productengine maxim-productengine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that moving to new timers requires minimal changes.
Also LLNotifications.lua will be redundant because we'll have popup.lua

@maxim-productengine maxim-productengine merged commit 3a2018d into lua-speedometer-demo Jun 20, 2024
7 checks passed
@maxim-productengine maxim-productengine deleted the nat/lua-speedometer-demo branch June 20, 2024 16:56
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2024
@nat-goodspeed
Copy link
Collaborator Author

Yes, I figure that once lua-speedometer-demo is merged into release/luau-scripting, I'll merge it into lua-login and then replace LLNotification.lua with popup.lua there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants