Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RequestTaskInventory capability #1604

Merged
merged 1 commit into from
May 31, 2024

Conversation

SaladDais
Copy link
Contributor

@SaladDais SaladDais commented May 31, 2024

See https://feedback.secondlife.com/feature-requests/p/move-object-inventory-listing-to-http-capability

Apparently there's been a capability for fetching LLSD object inventory added recently, use it in the viewer to make object inventory loads faster. Make the viewer prefer to load inventory via the capability rather than over the deprecated Xfer system, though both are still supported. Inventories that took several minutes to load now load in 0.5 seconds or so.

I don't totally understand some of the existing object inventory code related to obj->mInventorySerialNum and obj->mExpectedInventorySerialNum mismatches, but this code seems to behave correctly, might deserve some extra scrutiny.

I'm not sure if release/maint-b is the correct base branch to use here, but that's the one that builds Linux correctly for me, so that's the one I use :)

Copy link
Contributor

@marchcat marchcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

The overall changes look good.
Please address the comments above and sync your branch with release/maint-b. Once done, I'll be able to merge.

@marchcat marchcat added this to the Maintenance B milestone May 31, 2024
The viewer now prefers to load inventory via the capability rather than
over the deprecated Xfer system, though both are still supported.
@SaladDais
Copy link
Contributor Author

Rebased on top of current release/maint-b and squashed in fixes to address review feedback

@SaladDais SaladDais requested a review from marchcat May 31, 2024 18:35
@marchcat marchcat merged commit 854bed5 into secondlife:release/maint-b May 31, 2024
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2024
@SaladDais SaladDais deleted the llsd_inv branch May 31, 2024 21:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants