Project/channel by branch #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from main
|
So, using tags like |
nat-goodspeed
requested changes
May 1, 2024
nat-goodspeed
approved these changes
May 2, 2024
There was a problem hiding this comment.
I like it. I still think we should adopt Caladbolg's suggestion to trigger on something more informative, which suggests a smaller prefix. Now that we no longer use the content of tag name, I guess we could trigger on a tag like
Second_Life_branch_name#discriminator
but I think I'd rather see something like "build" or "release" or something short that conveys the intent of the tag.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use branch name to determine viewer_channel in build.yaml