Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

secondlife/viewer#912 BugSplat Crash 1412267: nvoglv64+0xadcd00 #1228

Merged
merged 1 commit into from
Apr 15, 2024
Merged

secondlife/viewer#912 BugSplat Crash 1412267: nvoglv64+0xadcd00 #1228

merged 1 commit into from
Apr 15, 2024

Conversation

LLGuru
Copy link
Contributor

@LLGuru LLGuru commented Apr 14, 2024

No description provided.

@LLGuru LLGuru requested a review from marchcat April 14, 2024 10:55
@LLGuru LLGuru force-pushed the guru/viewer-912-bugsplat-crash-nvoglv64 branch from 217e8cc to 541a90a Compare April 14, 2024 11:00
marchcat
marchcat approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@marchcat marchcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring.
Not sure if it'll help with the crash though.

akleshchev
akleshchev approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@akleshchev akleshchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nicer, but probably won't affect video driver crash.

P.S. Please link an issue before closing.

@LLGuru
Copy link
Contributor Author

LLGuru commented Apr 15, 2024

Nice refactoring.

Thanks

Not sure if it'll help with the crash though.

Refactoring really helps to see the logic of the algorithm
And when we see the logic we find points to fix like this:
image

@LLGuru LLGuru marked this pull request as ready for review April 15, 2024 21:39
@LLGuru LLGuru merged commit e4dd93e into release/maint-b Apr 15, 2024
11 checks passed
@LLGuru LLGuru deleted the guru/viewer-912-bugsplat-crash-nvoglv64 branch April 15, 2024 21:39
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akleshchev akleshchev akleshchev approved these changes

@marchcat marchcat marchcat approved these changes

Assignees
No one assigned
Labels
c/cpp llprimitive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LLGuru @akleshchev @marchcat