Feature/linux gtk removal #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove old GTK code and wire up some missing fltk logic in llfilepicker This will leave linux_crash_logger as an empy stub which could be used as a skeleton in case crash logging gets implemented. Otherwise linux_crash_logger and what is left of it in some cmake files can be deleted.
This revealed openal has also a dependebcy on sndio. Consequently the dependency was moved to OPENMAL.cmake and canot be dropped.
marchcat
requested changes
Apr 14, 2024
There was a problem hiding this comment.
Thank you for the contribution!
We have two build errors so far:
/home/runner/work/viewer/viewer/indra/newview/llfilepicker.cpp:1165:11: error: enumeration value 'FFSAVE_GLTF' not handled in switch [-Werror,-Wswitch]
switch ((ESaveFilter) filter)
^~~~~~~~~~~~~~~~~~~~
/home/runner/work/viewer/viewer/indra/newview/llfilepicker.cpp:1228:11: error: enumeration values 'FFLOAD_GLTF', 'FFLOAD_MATERIAL', and 'FFLOAD_MATERIAL_TEXTURE' not handled in switch [-Werror,-Wswitch]
switch ((ELoadFilter) filter)
^~~~~~~~~~~~~~~~~~~~
FFSAVE_GLTF,FFLOAD_GLTF, FFLOAD_MATERIAL, FFLOAD_MATERIAL_TEXTURE
Thank you for starting the builds. I fixed those missing cases. Sadly I do not get the error locally, so it is a bit of a shot in the dark and I hope there won't be any more incoming |
|
Thanks, starting a new build. |
|
@marchcat fyi, while looking at this I got a feeling those filetypes are also not handled for OSX (at least partially). I suggest someone with access to a Mac giving that a short investigation. |
marchcat
approved these changes
Apr 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will remove the last obsolete parts of LL_GTK
This source is not used anymore, would be highly outdated (targeting GTK2 ) and could not even be used, as there is no GTK 3P.