-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Linux media handling #1146
Update Linux media handling #1146
Conversation
We need libpulse-dev for volume_catcher Linux
…eds to be rebuilt and we do not have a fresh one from LL yet. Forcefully undefine LIB_NDOF, it gets defined in the build variables no matter if it is safe to define.
…ng to install 32 bit compat packages makes no sense at all
Builds passed. From my side this is good to go |
At least now it is peculiar shared magic with only one implementation.
…etermine this by reading "/sys/devices/system/cpu/cpu0/cpufreq/cpuinfo_max_freq". Only if this fails go back to /proc/cpuinfo
…flags are for which OS/compiler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution.
This looks fine to me and builds successfully.
@callumlinden, what do you think? |
@callumlinden <https://github.com/callumlinden>, what do you think?
I was about to start looking at the PR today - it's rather long so it will
take a while but I am on it.
…On Tue, Apr 9, 2024 at 10:03 AM Andrey Lihatskiy ***@***.***> wrote:
@callumlinden <https://github.com/callumlinden>, what do you think?
—
Reply to this email directly, view it on GitHub
<#1146 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3CNVM4FSNNPQG7XGLXL7S3Y4QNNXAVCNFSM6AAAAABF2IJ6ZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBVGY4DKNZRGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
CALLUM PRENTICE | *Principal Engineer*
LINDEN LAB | Create Virtual Experiences <http://www.lindenlab.com/>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since most of the changes are Linux specific, I wasn't able to offer much in the way of insight but at a high level at least, looks good to me.
This PR will: