Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Destinations ComboBox on Login Screen changes the selected item to the similar one #2471

Open
LLGuru opened this issue Aug 30, 2024 · 1 comment · Fixed by #2478 or #2496
Open
Labels
bug Something isn't working team:viewer

Comments

@LLGuru
Copy link
Contributor

LLGuru commented Aug 30, 2024

Environment

Any recent build

Description

When the Destination ComboBox contains 2 similar items in the list,
after choosing the second item of this pair and reopening the dropdown list
the selection is on the first item of the pair (a few rows upper the user choise)

Reproduction steps

Prerequisites: get 2 identical landmarks in the Favorites list

  1. Login to viewer
    Expected behavior: you see a few landmarks on the Favorites toolbar

  2. On the Favorites toolbar click "More" button
    Expected behavior: the small floater with the list of landmarks is opened

  3. At the bottom of the opened floater click "Open landmarks" (scroll the list down if needed)
    Expected behavior: The PLACES floater is opened with LANDMARKS tab selected

  4. On the PLACES floater select the first tab FAVORITES
    Expected behavior: the same list of landmarks as you have on the Favorites toolbar should be displayed in the floater

  5. Drag and drop any landmark from the Favorites toolbar to the list on the PLACES floater
    Expected behavior: you get 2 copies of the same landmark in the landmark list on the FAVORITES tab

  6. Drag and drop the new landmark in the PLACES floater a few rows below its copy
    Expected behavior: you get 2 copies of the same landmark in the landmark list on the FAVORITES tab

Steps to reproduce:

  1. Close the viewer
  2. Start the viewer again (do not login, stay on the login screen)
  3. Open the dropdown list of the Destinations ComboBox
  4. Select the second item of the pair of identical landmarks
  5. Close and open the dropdown list again

Expected behavior: the second item is still selected
Actual behavior: the first item of the pair is selected

@LLGuru LLGuru added bug Something isn't working triage Flags issues that need to be triaged labels Aug 30, 2024
@LLGuru LLGuru self-assigned this Aug 30, 2024
LLGuru added a commit that referenced this issue Sep 2, 2024
@akleshchev akleshchev added team:viewer and removed triage Flags issues that need to be triaged labels Sep 2, 2024
LLGuru added a commit that referenced this issue Sep 2, 2024
LLGuru added a commit that referenced this issue Sep 2, 2024
LLGuru added a commit that referenced this issue Sep 2, 2024
@LLGuru LLGuru removed their assignment Sep 2, 2024
@LLGuru LLGuru linked a pull request Sep 4, 2024 that will close this issue
@LLGuru LLGuru reopened this Sep 13, 2024
@AtlasLinden AtlasLinden added this to the Develop milestone Sep 13, 2024
logue added a commit to logue/viewer that referenced this issue Sep 19, 2024
commit 6d842ac0af814a088c56f437dc885e4ce58b61a8
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Wed Sep 18 17:11:03 2024 +0300

    Expose LLVector4a in LLRender

    Avoid using a bunch of allocators.
    Make sure we use LLVector4a's SSE logic instead of LLVector3's.
    Some minor optimizations.

commit b0597e927a04e622b2434e6fc8327bb5af48ab0f
Author: Brad Linden <brad@lindenlab.com>
Date:   Wed Sep 18 20:04:24 2024 -0700

    add some more whitespace commits to .git-blame-ignore-revs

commit a36cf18bab5eb45e8784502f0d8ba47d20d952c8
Merge: ecfd66fb09 743a1a6d8e
Author: Roxanne Skelly <roxanne@roxiware.com>
Date:   Wed Sep 18 19:13:49 2024 -0700

    Merge pull request #2602 from secondlife/roxie/webrtc-2601

commit ecfd66fb094cf46a73c164d8a1b655489d037aec
Author: Brad Linden <46733234+brad-linden@users.noreply.github.com>
Date:   Wed Sep 18 18:17:02 2024 -0700

    Avoid LL_ERRS when wgl_ARB_pixel_format is not supported (#2606)

    secondlife/viewer#2599

commit c5a2235e7a249c01999795f45ceb4697150dc3e1
Author: Brad Linden <46733234+brad-linden@users.noreply.github.com>
Date:   Wed Sep 18 18:16:24 2024 -0700

    Turn off sLogInSignal to avoid crashing. (#2607)

    fixes secondlife/viewer#2566

commit ee3645ac961aec171cc56ec962723ac5fd28cf38
Author: Ansariel Hiller <Ansariel@users.noreply.github.com>
Date:   Thu Sep 19 00:22:48 2024 +0200

    Fix possible dereferencing of nullptr in llglsandbox.cpp (#2597)

commit 2fd18ee162824e449dc893c66d7dd8c56518ee7c
Author: Ansariel Hiller <Ansariel@users.noreply.github.com>
Date:   Thu Sep 19 00:21:22 2024 +0200

    Fix copy&paste error in llfloaterimagepreview.cpp (#2596)

commit 9fa95dd0b21f323b7d8f60a826bcc128ad4e7ef2
Author: Brad Linden <46733234+brad-linden@users.noreply.github.com>
Date:   Wed Sep 18 14:53:36 2024 -0700

    Fix crash in LLImProcessing when message comes in before region is fully init (#2604)

    secondlife/viewer#2603

commit 743a1a6d8eabf069d95777c96e5b657cb8702593
Author: Roxie Linden <roxie@lindenlab.com>
Date:   Wed Sep 18 14:14:26 2024 -0700

    fix trailing whitespace

commit 1dcbae822d4b3dfae43e8d6c6a512773e83b588d
Merge: b31fd167c0 9890b5b2e7
Author: Brad Linden <46733234+brad-linden@users.noreply.github.com>
Date:   Wed Sep 18 13:44:22 2024 -0700

    Merge pull request #2600 from secondlife/brad/1016-cherry-pick

    cherry-pick viewer#1016 Incorrect behavior of Physics Shapes rendering

commit b31fd167c00a288656ea82d239a9ce379f382c22
Author: Dave Parks <davep@lindenlab.com>
Date:   Wed Sep 18 15:23:20 2024 -0500

    Fix for particles not loading textures (#2598)

    Also fix assert while prepping GLTF assets

commit 4640f3204d87ebde9f12ea9c6c13beb6d77cdca2
Merge: 27b8e6d576 9241fb8058
Author: Brad Linden <brad@lindenlab.com>
Date:   Wed Sep 18 13:12:17 2024 -0700

    Merge remote-tracking branch 'origin/main' into develop

commit 52091a6097cd4e68f3fc1b0972080867ceb09122
Author: Roxie Linden <roxie@lindenlab.com>
Date:   Wed Sep 18 13:01:43 2024 -0700

    Mute other / set volume level for other is not working.

    As part of the boost::json conversion, the json that mutes and sets peer gain
    was not being formed correctly.

    Also, tweaked the peer gain default.

commit 9890b5b2e7f24a8ad52456d80ddfec0e4e505d96
Author: Brad Linden <brad@lindenlab.com>
Date:   Wed Sep 18 12:26:11 2024 -0700

    added .git-blame-ignore for last commit

commit 5370a6d323e14d7b4e32a3f41ef78f7744e361c5
Author: Brad Linden <brad@lindenlab.com>
Date:   Wed Sep 18 12:23:14 2024 -0700

    fix whitespace

commit d6e10ba4b0e08c29b16ea62e0f8b7d1835418903
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Mon Mar 25 15:50:47 2024 +0200

    viewer#1016 Incorrect behavior of Physics Shapes rendering

commit 27b8e6d576346e3174760087a15811478a90459e
Author: Alexander Gavriliuk <alexandrgproductengine@lindenlab.com>
Date:   Wed Sep 18 11:44:03 2024 +0200

    #2408 The long covenant with emojis significantly slows down some operations in the viewer

commit d9da5bbb33ce70e3bc799ba6696c8b10de0e5f04
Author: Ansariel Hiller <Ansariel@users.noreply.github.com>
Date:   Wed Sep 18 16:09:51 2024 +0200

    Remove quads rendering mode entirely (#2593)

commit 83cf25af8d05897986cfbcf27224bf69fe7544c6
Author: Pantera Północy <panterapolnocy@gmail.com>
Date:   Wed Sep 18 15:26:32 2024 +0200

    Tiny argument names correction (tittle -> title) (#2594)

commit 689d9e6935421879229909ec11b41a1524e64b33
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Tue Sep 17 18:57:10 2024 +0300

    More quad to triangle coverage

    Quads are deprecated

commit 3327ae7938499c4410556bef24662bb9f65274e8
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Tue Sep 17 18:46:44 2024 +0300

    Convert image drawing logic from quads to triangles

commit 55f2103adc36db0d3f068a31a144e15465226e13
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Fri Sep 13 20:50:19 2024 +0300

    viewer#2565 Optimize LLFolderViewItem::draw()

commit 0a617904f98ab5960379099822e4891a08137e68
Author: Dave Parks <davep@lindenlab.com>
Date:   Tue Sep 17 18:14:22 2024 -0500

    #2590 Fix for horrible FPS on Intel Mac (#2591)

    * Work around for GHA mac runners not playing nice with Tracy
    * Delay VBO deletion for a few frames
    * Enable multithreaded GL driver and multithreaded media textures on Apple silicon

commit 9241fb80588304f89c035e9811af96172982a8c2
Author: Nat Goodspeed <nat@lindenlab.com>
Date:   Tue Sep 17 15:26:22 2024 -0400

    Increment viewer version to 7.1.11
    following promotion of secondlife/viewer #2367: 2024.08 DeltaFPS

commit fd843d514a4e28f8e4a5d5595bba21ccad195e72
Author: Dave Parks <davep@lindenlab.com>
Date:   Tue Sep 17 13:07:01 2024 -0500

    Mac pass (#2587)

commit 870ffbd55b4ffdfad27edf8824de0c9cbc577a80
Author: Dave Parks <davep@lindenlab.com>
Date:   Tue Sep 17 12:43:47 2024 -0500

    Suppress mapBuffer warnings. (#2584)

commit f378d2f95ad751ccf7456f79baba61d6c39f5c36
Author: Ansariel Hiller <Ansariel@users.noreply.github.com>
Date:   Tue Sep 17 02:10:24 2024 +0200

    Fix Visual Studio complaints in LLTrans (#2575)

commit 486613e79bb96b838121f627ef73b1293ee18c12
Author: Dave Parks <davep@lindenlab.com>
Date:   Mon Sep 16 18:49:03 2024 -0500

    Profile guided optimization pass (#2582)

    - Tune up LLJointRiggingInfoTab
    - Visualize joint bounding boxes when visualizing joints
    - Use LLJointRiggingInfo to caclulate desired resolution of a texture
    - Throttle calls to calcPixelArea
    - Fetch MeshSkinInfo immediately when header is received

commit 42975dfd8868454172ca0c3fcfa9ae18cb1d4de8
Merge: eac0c748a2 85a7020e49
Author: Rye Mutt <rye@lindenlab.com>
Date:   Mon Sep 16 16:46:14 2024 -0700

    Merge pull request #2580 from RyeMutt/2kbom

    Raise resolution of local baked texture preview from 512 to 2048

commit eac0c748a2f650a7875e29e9ccc65522f485911b
Author: Rye Mutt <rye@lindenlab.com>
Date:   Mon Sep 16 15:59:34 2024 -0700

    Fix noise post effect due to missing uniform (#2581)

commit 7594e3b71b24313b351ab4ca69899aa8584c0c1b
Merge: 2f38f0685c e3c3cc636e
Author: Brad Linden <46733234+brad-linden@users.noreply.github.com>
Date:   Mon Sep 16 14:46:21 2024 -0700

    Merge pull request #2578 from secondlife/brad/2550-plugin-shutdown-crash

    Fix for crash in LLPluginProcessParent during early shutdown.

commit e3c3cc636e66043fa89f402c9f132c208f0217cd
Author: Brad Linden <brad@lindenlab.com>
Date:   Mon Sep 16 13:14:14 2024 -0700

    Fix for crash in LLPluginProcessParent during early shutdown.

    fixes secondlife/viewer#2550

commit 85a7020e4903e83701c3f1ccbc9a14bd84c9368b
Author: Rye Cogtail <rye@lindenlab.com>
Date:   Fri Sep 13 16:26:23 2024 -0400

    Raise resolution of local baked texture preview from 512 to 2048

commit 2f38f0685cf3031f6108de2a7c312aa4cf0462bd
Merge: 74205607b7 da87e8bd37
Author: Andrew Meadows <andrew.l.meadows@gmail.com>
Date:   Fri Sep 13 11:48:51 2024 -0700

    Merge pull request #2569 from secondlife/leviathan/send_agent_update

    send AgentUpdate ASAP when control bits change

commit da87e8bd370ea079576f8b412a4ddb80c0715bd1
Author: leviathan <leviathan@lindenlab.com>
Date:   Fri Sep 13 10:47:24 2024 -0700

    send AgentUpdate ASAP when control bits change

commit 74205607b7e106f3b7566ef4a4b9c2fcdfa2f83e
Author: Ansariel Hiller <Ansariel@users.noreply.github.com>
Date:   Fri Sep 13 16:28:48 2024 +0200

    Clean up Windows build (#2562)

    * APR_DECLARE_STATIC and APU_DECLARE_STATIC gets already defined in APR.cmake
    * Move both _CRT_SECURE_NO_WARNINGS and _WINSOCK_DEPRECATED_NO_WARNINGS definitions to 00-Common.cmake
    * Always define WIN32_LEAN_AND_MEAN and include subset of Windows API by default
    * Remove llwin32headerslean.h and remove unnecessary WIN32_LEAN_AND_MEAN definition handling in llwin32headers.h
    * Clean up includes of Windows API headers
    * Get rid of workaround to link against IPHLPAPI.lib in lluuid.cpp - this seems to have been an issue in the past that has been fixed

commit c892ce9f5cf7582a1eb5ed27de117eedf3c2addc
Merge: 1e1010bbf2 f568fe6655
Author: Rye Mutt <rye@lindenlab.com>
Date:   Thu Sep 12 22:45:56 2024 -0700

    Merge pull request #2563 from RyeMutt/fix-macos-locale

    Fix macOS locale not being set due to missing locale strings

commit 1e1010bbf27c57d8d5ec6701d08df50c21bd11d0
Merge: a3f6f98f1b e71215dcfd
Author: Andrey Kleshchev <117672381+akleshchev@users.noreply.github.com>
Date:   Fri Sep 13 08:02:04 2024 +0300

    Merge pull request #2545 for viewer#2529 Improve environment's performance

commit f568fe6655bd52f32fd6987f0bcac8f88a9b6e01
Author: Rye Cogtail <rye@lindenlab.com>
Date:   Thu Sep 12 22:40:16 2024 -0400

    Fix macOS locale not being set due to missing locale strings

commit a3f6f98f1b79e3d57ae67114db409297cd625310
Merge: 7dd04dea9f f4c53518d7
Author: Brad Linden <46733234+brad-linden@users.noreply.github.com>
Date:   Thu Sep 12 15:27:26 2024 -0700

    Merge pull request #2561 from secondlife/brad/2553-about-sl-crash-locale-init

    secondlife/viewer#2553 about sl crash locale init

commit 7dd04dea9fb6882f4a7c8a5a5b79ace84838ae0e
Merge: ccbd69bf6b 3c5e8ded93
Author: Brad Linden <46733234+brad-linden@users.noreply.github.com>
Date:   Thu Sep 12 15:25:56 2024 -0700

    Merge pull request #2557 from secondlife/davep-fix-mac-vb

    OS X - Fix black screen and Tracy build

commit f4c53518d71180e4ba10b7b7c66bab9d26ec13a4
Author: Brad Linden <brad@lindenlab.com>
Date:   Thu Sep 12 15:04:03 2024 -0700

    Attempted fix for mac crash when showing About Second Life.

    secondlife/viewer#2553

commit bb9a2dd75bce568c5eef596b69a503270994e0ba
Author: Brad Linden <brad@lindenlab.com>
Date:   Thu Sep 12 15:03:44 2024 -0700

    Fix for mac build with tracy enabled.

commit ccbd69bf6b287861b41fdb00e9d372746dfc2702
Author: Alexander Gavriliuk <alexandrgproductengine@lindenlab.com>
Date:   Thu Sep 12 20:35:35 2024 +0200

    #2166 Avatar does not move its lips when the corresponding checkbox is checked

commit 1894136e9a6e25b27acfffdc2a92afc08fce012a
Merge: b713f56d07 44e1be64e0
Author: Roxanne Skelly <roxie@lindenlab.com>
Date:   Thu Sep 12 09:46:20 2024 -0700

    Merge pull request #2543 from secondlife/roxie/webrtc-285

    mute icons were not showing during group call when user was muted

commit b713f56d07cffb21cad5928bf30d6d4b6dc79de9
Author: Rye Mutt <rye@lindenlab.com>
Date:   Thu Sep 12 09:22:10 2024 -0700

    Replace glh_linear usage with GLM (#2554)

commit 3c5e8ded9399dc1419b8596c99f2a1ef9656b7bb
Merge: 61990bfd69 264c57831b
Author: Dave Parks <davep@lindenlab.com>
Date:   Thu Sep 12 11:08:27 2024 -0500

    Merge branch 'develop' into davep-fix-mac-vb

commit 61990bfd6992ca1c4ee2df2795a469f67b085968
Author: Dave Parks <davep@lindenlab.com>
Date:   Thu Sep 12 11:06:05 2024 -0500

    Fix for tracy not working on mac

commit 14a3c7573652e669c35dd331214f572da985c2a9
Author: Dave Parks <davep@lindenlab.com>
Date:   Thu Sep 12 11:05:14 2024 -0500

    Mac compatibility pass.

commit 264c57831bc6ca9be1c465c10a2558c3d28b936e
Author: Rye Mutt <rye@lindenlab.com>
Date:   Thu Sep 12 09:00:58 2024 -0700

    Fix warning spam from missing call to unmapBuffer introduced in #2544 (#2556)

commit e71215dcfdb960f64a7f10d2fba71790f8e7bcd1
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Thu Sep 12 14:32:43 2024 +0300

    viewer#2529 Optimize LLSettingsWater::blend

commit 1f6423214c9f8db374970c1b876a16e098697e64
Author: Maxim Nikolenko <maximnproductengine@lindenlab.com>
Date:   Thu Sep 12 18:23:47 2024 +0300

    Don't allow LLAttachmentsMgr to iterate COF items when there is no questionable links there

commit 33c8fd2acc1ed1c13429c963d431adc8f4d8100e
Author: Alexander Gavriliuk <alexandrgproductengine@lindenlab.com>
Date:   Thu Sep 12 06:00:00 2024 +0200

    #2542 Buoyant Nametags

commit 0c7cb663fc108249e5477fd90978fc1f74fe7b7e
Merge: 1a65e29432 f78b43bd1d
Author: Roxanne Skelly <roxie@lindenlab.com>
Date:   Wed Sep 11 23:50:08 2024 -0700

    Merge pull request #2551 from secondlife/roxie/webrtc-1436

    Fix issue with improper reporting as to whether voice is working.

commit 1a65e294327f6dd680d5a3d6103bb82b78d5adfb
Author: Ansariel Hiller <Ansariel@users.noreply.github.com>
Date:   Thu Sep 12 08:18:45 2024 +0200

    Fix names in group chat sometimes showing as "Loading..." and never resolve (#2547)

commit 5f622a071c1682fd86b2d8365a58aaa90aee8809
Author: Ansariel Hiller <Ansariel@users.noreply.github.com>
Date:   Thu Sep 12 08:18:34 2024 +0200

    Fix incorrect operator warning and possible dereferencing of null pointer (#2546)

commit f78b43bd1d4a96db32a64e18d88c3768531ceee8
Author: Roxie Linden <roxie@lindenlab.com>
Date:   Wed Sep 11 15:58:56 2024 -0700

    Fix issue with improper reporting as to whether voice is working.

    This fixes #1436, an issue where the 'call button' sometimes got greyed
    out when it shouldn't have been.

    Vivox is now 'working' (and the call button can be enabled) when it's logged in.
    WebRTC is 'working' (and the call button can be enabled) when the coroutine is active.

commit dfff269d83df60de49fe8e5d7fffe9d1913e8036
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Wed Sep 11 20:05:26 2024 +0300

    viewer#2529 Optimize LLSettingsSky::blend

commit 0a110ff0833216b167e032987b0d676f29ad0ee5
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Wed Sep 11 18:21:03 2024 +0300

    viewer#2529 Track interpolateSDMap's performance

    viewer#2529 Fix initialization

commit 047eb16f4c8fdfb1826136db9ee2eed83cb95416
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Tue Sep 10 23:07:07 2024 +0300

    viewer#2529 Optimize updateGLVariablesForSettings

    Intent is to eventually use only stored variables for everything.
    LLSD operations are far too expensive.

commit d6eafa1bdbcfa69d60d2d7340c331e34d6915500
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Tue Sep 10 19:26:16 2024 +0300

    Make updateKeyboardFocus a bit more efficient

commit f90712b9837957f2a0d11386c6bf48e9a48ff745
Merge: 13e74a3287 cde5d29faf
Author: cosmic-linden <111533034+cosmic-linden@users.noreply.github.com>
Date:   Tue Sep 10 17:38:32 2024 -0700

    Merge pull request #2544 from secondlife/davep-profile-session-9/10

    Profile guided optimizations

commit cde5d29faf84c5cb7fc1b0d0ff6d03f3b7354c8f
Author: RunitaiLinden <davep@lindenlab.com>
Date:   Tue Sep 10 18:27:45 2024 -0500

    Profile guided optimizations

commit 13e74a32871c7c8f7c7556c6fc08150fc6f27876
Merge: ce23e4a0c3 94453aecc3
Author: Brad Linden <brad@lindenlab.com>
Date:   Tue Sep 10 16:12:38 2024 -0700

    Merge remote-tracking branch 'origin/release/2024.08-DeltaFPS' into develop

commit 44e1be64e0a212fb77cc6ef4664d444242d62e67
Author: Roxie Linden <roxie@lindenlab.com>
Date:   Tue Sep 10 11:53:54 2024 -0700

    mute icons were not showing during group call when user was muted

    This fixes: https://github.com/secondlife/viewer-private/issues/285

    When processing messages from the voice server, the volume and not the
    mute status was being checked with respect to retrieving the mute status.

commit ce23e4a0c3e1e408afaef20887b619241225a8d2
Author: Alexander Gavriliuk <alexandrgproductengine@lindenlab.com>
Date:   Tue Sep 10 17:21:18 2024 +0200

    #2460 Max-Non-Impostors uses a bad shape (code formatting)

commit 1c1522fc7ce6c29af5a1c801041e670d47a2ead1
Author: Alexander Gavriliuk <alexandrgproductengine@lindenlab.com>
Date:   Tue Sep 10 17:12:18 2024 +0200

    #2460 Max-Non-Impostors uses a bad shape

commit 94453aecc352613f52fec0e59b23230314cffb32
Author: Dave Parks <davep@lindenlab.com>
Date:   Tue Sep 10 15:54:01 2024 -0500

    #2434 Intel HD4000 compatibility pass (#2541)

    * #2434 Intel HD4000 compatibility pass
    * Fixes crash on old drivers when loading shaders
    * Fixes 30 second hang on startup
    * Fixes occasional dev build crash in LLWearableList
    ---------

    Co-authored-by: Brad Linden <brad@lindenlab.com>

commit d5328ef226a470584b086d6bf4d80e8911e1e7df
Merge: 59676066cd 761a4fa429
Author: nat-goodspeed <nat@lindenlab.com>
Date:   Tue Sep 10 15:08:03 2024 -0400

    Merge pull request #2536 from Ansariel/develop-viewermenu-cleanup

    Clean up llviewermenu

commit 59676066cd740abb3002225ad67259e3dc09ab45
Merge: 100fab22f5 9ffbca2489
Author: Maxim Nikolenko <maximnproductengine@lindenlab.com>
Date:   Tue Sep 10 19:48:36 2024 +0300

    Merge pull request #2539 from secondlife/maxim/viewer_2443

    Allow the in world voice indicator to be toggled in preferences

commit 9ffbca2489d5a556228717c09f86c2d28b6c8d73
Author: Mnikolenko Productengine <mnikolenko@productengine.com>
Date:   Tue Sep 10 19:15:58 2024 +0300

    Allow the in world voice indicator to be toggled in preferences

commit 761a4fa4291b4cbef0b2056c6a0b1f449c0cb4bf
Author: Ansariel <ansariel.hiller@phoenixviewer.com>
Date:   Tue Sep 10 13:54:38 2024 +0200

    Clean up llviewermenu

commit 100fab22f56969a6abe15b0dd58881002db02ab3
Merge: b7c82a8e7a 5f99c475dc
Author: Roxanne Skelly <roxanne@roxiware.com>
Date:   Mon Sep 9 16:21:20 2024 -0700

    Merge pull request #2535 from secondlife/roxie/webrtc-1091

commit 5f99c475dc89bd6293d157e85ad67cf6c832f578
Author: Roxie Linden <roxie@lindenlab.com>
Date:   Mon Sep 9 15:12:40 2024 -0700

    Voice bars of self and as seen by others do not appear the same.

    The voice server sends up the float power level of peers as an integer
    multiplied by 128, in order to save character count as the voice power level
    will likely be only 3 digits, instead of many for a full float.

    The client was not taking this into account.

commit b7c82a8e7a5efcf56cf8c60ecc4922cf2942b70e
Merge: 33116ea35e 9d8376071a
Author: Roxanne Skelly <roxie@lindenlab.com>
Date:   Mon Sep 9 14:06:55 2024 -0700

    Merge pull request #2533 from secondlife/roxie/webrtc-283

    Callback button for groups was not being reenabled after hanging up on group call.

commit 9d8376071a9c943613a2f6e4fdc3e681e36b7fdb
Author: Roxie Linden <roxie@lindenlab.com>
Date:   Mon Sep 9 11:52:16 2024 -0700

    Callback button for groups was not being reenabled after hanging up on group call.

    For #2532, callback button was remaining disabled after hanging up on a group call.

    Also, fix an issue where user was automatically added to a group call after the
    initiator of the group call hangs up and re-calls the group.

commit 33116ea35ec9a925c1601c8f1833e4d1e9f8390b
Merge: f3f3f99fcf 1f754e5090
Author: Brad Linden <46733234+brad-linden@users.noreply.github.com>
Date:   Mon Sep 9 10:28:57 2024 -0700

    Merge pull request #2530 from secondlife/release/2024.08-DeltaFPS

    Release/2024.08 delta fps

commit f3f3f99fcf28dde7bb0e9dc7459be12beb1dfe16
Merge: 71c46bc629 782facee39
Author: Maxim Nikolenko <maximnproductengine@lindenlab.com>
Date:   Mon Sep 9 17:57:49 2024 +0300

    Merge pull request #2527 from secondlife/maxim/viewer_2473

    Reduce 'World map' floater draw time

commit 782facee39a62567d958ad85c42cb4c43de603ab
Author: Mnikolenko Productengine <mnikolenko@productengine.com>
Date:   Mon Sep 9 14:26:00 2024 +0300

    Reduce 'World map' floater draw time

commit 71c46bc6299ee27191b5a4610d066ace593f0fca
Author: Kyler "Félix" Eastridge <felix.wolfz@gmail.com>
Date:   Mon Sep 9 06:45:34 2024 -0400

    Fix spelling error in variable name (#2526)

commit d91d39fa0f7f4f204d6fb7ff66b9817e498dbd61
Author: Ansariel Hiller <Ansariel@users.noreply.github.com>
Date:   Mon Sep 9 12:02:34 2024 +0200

    Changes towards C++20 compatibility (#2520)

commit 2f692fbac36117e1b3c5f2ec214fd188c7e73da7
Author: TommyTheTerrible <81168766+TommyTheTerrible@users.noreply.github.com>
Date:   Mon Sep 9 05:31:00 2024 -0400

    Update calcDataSizeJ2C to stop undersized blocks (#2525)

    The initial block area for the pyramid walk should not be smaller than the max_block_size area so need an llmax to not allow multiplication below 1.

    This was causing decode errors for complex small images (128x128 or smaller) on discard 1 and 2.

commit 2b7b81fbdbaaaa8698828af9529f9693692da2a2
Author: Alexander Gavriliuk <alexandrgproductengine@lindenlab.com>
Date:   Tue Sep 3 18:05:45 2024 +0200

    #459 Filters on object inventory

commit 2e886b7cfef14d087c2167e3384e9e19dcb3ff63
Merge: 9ce23ccc5e 4a00280b89
Author: Andrey Kleshchev <117672381+akleshchev@users.noreply.github.com>
Date:   Sat Sep 7 20:20:18 2024 +0300

    Merge pull request #2521 from secondlife/andreyk/viewer_2411

    viewer#2411 Use font buffer for inventory

commit 1f754e50908ba325c132b8d83383f7f0dbbdf793
Author: Dave Parks <davep@lindenlab.com>
Date:   Fri Sep 6 16:39:58 2024 -0500

    #2467 Fix for sim surrounds not fully loading (#2524)

    Also fixes some sculpts getting wrong LoD

commit 4a00280b892ea82d2c0732ab52778a2c19bdc810
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Fri Sep 6 20:13:17 2024 +0300

    viewer#2411 Use font buffer for inventory

commit 9ce23ccc5ea75442fd44173befdadaf6cc9d2ec2
Merge: 6af471482d 3017b1bae1
Author: Roxanne Skelly <roxie@lindenlab.com>
Date:   Fri Sep 6 13:40:25 2024 -0700

    Merge pull request #2522 from secondlife/roxie/webrtc-281

    Don't enable vivox spatial when teleporting while in a webrtc conference/p2p/group call

commit 3017b1bae163881b0ef9aff3071865431970927b
Author: Roxie Linden <roxie@lindenlab.com>
Date:   Fri Sep 6 12:00:00 2024 -0700

    Don't enable vivox spatial when teleporting while in a webrtc conference/p2p/group call

    Processing for vivox was being enabled when teleporting into a vivox region
    regardless as to whether the user was in a conference/p2p/group call, resulting
    in vivox spatial and webrtc conference/p2p/group simultaneously being active.

commit 6af471482d6801530915c1c9ae4bdf788af52eae
Author: TJ <tj8@live.com.au>
Date:   Sat Sep 7 00:08:32 2024 +1000

    Add toggles to avatar dropdown for hear sound or voice from avatar. (#2518, #2519)

commit 256ac6e9627073903614263476f357f368082edb
Author: Ansariel Hiller <Ansariel@users.noreply.github.com>
Date:   Fri Sep 6 15:58:50 2024 +0200

    Fix login progress always showing incorrect attempt number (#2517)

commit 322b13cf95608963c93442c4d073e175f51c981a
Merge: 33fbcd858f 3c471b8155
Author: Andrey Kleshchev <117672381+akleshchev@users.noreply.github.com>
Date:   Fri Sep 6 09:44:09 2024 +0300

    Merge pull request #2516 from Ansariel/develop-inventory_item_count

    Follow-up fix for 238a2a64b31e6a0b431309e363067a7fe57125ae

commit 3c471b81554d9727b1a1929681ce3bfb4734aabc
Author: Ansariel <ansariel.hiller@phoenixviewer.com>
Date:   Fri Sep 6 02:20:10 2024 +0200

    Follow-up fix for 238a2a64b31e6a0b431309e363067a7fe57125ae: Item count will always show fetch label even after fetch is complete

commit 33fbcd858ff16f8e8bc9a071f0639f47b1f688ce
Merge: a617dc8fab fe9596bf79
Author: Roxanne Skelly <roxie@lindenlab.com>
Date:   Thu Sep 5 15:07:00 2024 -0700

    Merge pull request #2514 from secondlife/roxie/webrtc-race

    Fix race condition that was preventing "Voice Call" menu from reliably calling.

commit fe9596bf79659b2dd334fa6332473c8284df7659
Author: Roxie Linden <roxie@lindenlab.com>
Date:   Thu Sep 5 12:07:51 2024 -0700

    Fix race condition that was preventing "Voice Call" menu from reliably calling.

    The code attempted to do a call to a session immediately after a call that
    launched a coroutine to set up a session.  Sometimes, the coroutine executed
    in time, sometimes not.

    The fix is to set a flag to start a call after the session has been created
    on the server.

    Test Plan:
    * Close all active chat sessions.
    * Select 'Voice Call' in the context menu of a nearby avatar.
    * Validate popup appears for that nearby avatar requesting to start/ignore/go to im.
    * Select 'start'
    * Validate the call completes.

commit a861e86398e5d3fde9ffb388b2ccfc3624b3a5f7
Author: Dave Parks <davep@lindenlab.com>
Date:   Thu Sep 5 12:08:47 2024 -0500

    #2482 Fix for Quadro GPUs claiming to have infinite VRAM (#2511)

commit a617dc8fab45353664dbec2d87845ea3af04319a
Merge: c963baeedb d9f0a587a8
Author: Roxanne Skelly <roxie@lindenlab.com>
Date:   Thu Sep 5 09:19:48 2024 -0700

    Merge pull request #2506 from secondlife/roxie/webrtc-1392

    Fix some race conditions on webrtc connection shutdown.

commit c963baeedbf943b54e09b3eabf7bfa45703b7c7c
Merge: bacf9cfeab 8c65a61b09
Author: Rye Mutt <rye@lindenlab.com>
Date:   Thu Sep 5 08:50:01 2024 -0700

    Merge pull request #2510 from RyeMutt/openxr

    Introduce OpenXR SDK prebuilt package and cmake setup

commit bacf9cfeab90bd1ffad827fa3c34ced985c768a2
Author: TJ <tj8@live.com.au>
Date:   Thu Sep 5 23:55:02 2024 +1000

    Fixed md5 buffer not being correctly zero-initialized and refactored code. (#2507)

commit 61627f6524fdb6e723fef71312b23f75a6799a65
Author: Alexander Gavriliuk <alexandrgproductengine@lindenlab.com>
Date:   Wed Sep 4 23:51:42 2024 +0200

    #2461 changing the color of my dot on the minimap

commit 494ac09216c547cd62ebd43f57056807bb46d49c
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Wed Sep 4 19:22:49 2024 +0300

    viewer#2411 Confine font vertex buffers to static text segments

    Collection of vertex buffers happens to often with segmented text.

commit 442ee9795ecde5a89df254b78465c8f4ed46845f
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Wed Sep 4 15:40:11 2024 +0300

    viewer#2411 Use font buffer in line editor

commit 238a2a64b31e6a0b431309e363067a7fe57125ae
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Wed Sep 4 13:42:11 2024 +0300

    viewer#2411 Use font buffer in text segments

commit 8c65a61b095545b88ecb0820fa0e6ccd484d242a
Author: Rye Cogtail <rye@lindenlab.com>
Date:   Wed Sep 4 23:10:13 2024 -0400

    Introduce OpenXR SDK prebuilt package and cmake setup (#2503)

commit d9f0a587a88373dbe839afd6489bc9a1ca4edeea
Author: Roxie Linden <roxie@lindenlab.com>
Date:   Wed Sep 4 15:45:03 2024 -0700

    Fix some race conditions on connection shutdown.

    In a few locations, there were cases where connection shutdown
    would stall, leaving the connection in place.  This was due to
    bad handling of the outstanding operations counter.

commit 49abe2c8bc23e306d304d02704e2b883648baea6
Merge: c2724537ad d5446b3bcd
Author: Brad Linden <brad@lindenlab.com>
Date:   Wed Sep 4 12:51:24 2024 -0700

    Merge remote-tracking branch 'origin/release/2024.08-DeltaFPS' into develop

commit d5446b3bcd34ad63b1d120f34c2a4d234262fd38
Merge: 2a188ab306 e168598045
Author: Brad Linden <46733234+brad-linden@users.noreply.github.com>
Date:   Wed Sep 4 12:45:17 2024 -0700

    Merge pull request #2504 from secondlife/brad/cherry-pick-2492

    cherry pick fix for #2490 into DeltaFPS

commit e16859804561272fb257b73f4d7558a74045ca2b
Author: Cosmic Linden <cosmic@lindenlab.com>
Date:   Tue Sep 3 17:53:21 2024 -0700

    secondlife/viewer#2490: Fix PBR terrain texture transform feature flag handled by viewer in unpredictable manner

commit 2a188ab306041f28dc40877da1e93ad13f36f8a5
Author: Brad Linden <46733234+brad-linden@users.noreply.github.com>
Date:   Wed Sep 4 10:42:59 2024 -0700

    Fix another 1856 crash on startup case when Terrain Bake shaders are unsupported (#2491)

    fixes secondlife/viewer#1856

commit c2724537adab9d31c23d33e36002772a9c56f4c3
Author: TJ <tj8@live.com.au>
Date:   Thu Sep 5 02:42:01 2024 +1000

    Fixed missing comma in list. Fixed loop with too small loop variable. (#2497)

commit cb9f3dcfe9a55789b757bf5a7d9af3d93710c20f
Author: Dave Parks <davep@lindenlab.com>
Date:   Wed Sep 4 11:34:44 2024 -0500

    #2482 Low end NVIDIA compatibility pass (#2486)

    - Use GL_NVX_gpu_memory_info when available
    - Disable transparent water on Mid+ and lower
    - Adjust GPU benchmark to better tell the truth
    - Texture bias tune up
    - viewer-private/#277 - Report foreground_time in viewer stats

commit bd266a4a8605891a75c9a4efc783e8006e6b2fab
Merge: f1e0fc68e7 0f166a199d
Author: cosmic-linden <111533034+cosmic-linden@users.noreply.github.com>
Date:   Wed Sep 4 09:21:28 2024 -0700

    Merge pull request #2492 from secondlife/v-2490

    secondlife/viewer#2490: Fix PBR terrain texture transform feature flag handled by viewer in unpredictable manner

commit f1e0fc68e78d732ff433bb83c0c894ed23bbf3b2
Author: Alexander Gavriliuk <alexandrgproductengine@lindenlab.com>
Date:   Wed Sep 4 16:31:39 2024 +0200

    #2471 The Destinations ComboBox on Login Screen... (quick fix)

commit 2fc8d5ff3cfa1b9ad00b310cd4a6cdb557b9415c
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Tue Sep 3 17:22:04 2024 +0300

    viewer#2411 Cleanup #2

commit 4cc0edb189c4deaa205f986d20a6959aa83fb25c
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Mon Sep 2 22:14:42 2024 +0300

    viewer#2411 Cleanup

commit 57ab1a410f9cb3534bb403e034743505758579d8
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Mon Sep 2 13:46:13 2024 +0300

    viewer#2411 A bit more coverage for font buffer

commit 5c64e5e13d9a75cac510aac3128fc6ee780ab243
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Fri Aug 30 18:51:48 2024 +0300

    viewer#2411 LLFontGL::render optimizations #3

commit a638d9610d9f369eca6dff74e8860ca466c253c7
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Thu Aug 29 18:49:10 2024 +0300

    viewer#2411 LLFontGL::render optimizations #2

commit 2bae8dfb815cf4d04cb4882c2fb889e3fb9666b2
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Thu Aug 29 17:03:00 2024 +0300

    Remove usused LLButton::mBorderEnabled

commit 4ae1de1f8a78d795958d67afab8356f9a13f707d
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Wed Aug 28 23:05:58 2024 +0300

    viewer#2411 LLFontGL::render optimizations

commit 0f166a199d9a3deb82dd42dc5c68d72a2ca07165
Author: Cosmic Linden <cosmic@lindenlab.com>
Date:   Tue Sep 3 17:53:21 2024 -0700

    secondlife/viewer#2490: Fix PBR terrain texture transform feature flag handled by viewer in unpredictable manner

commit 891219dcef44583070e7487d0b6a4e57ad954667
Author: Dave Parks <davep@lindenlab.com>
Date:   Tue Sep 3 19:47:32 2024 -0500

    #1852 Fix for some visual corruption caused by divide by zero in lighting functions (#2488)

commit 36423bd6603c5708028c6e8e9705587b961a4bb2
Merge: ceed015e4e dfae0d9d78
Author: Rye Mutt <rye@lindenlab.com>
Date:   Tue Sep 3 16:02:15 2024 -0700

    Merge pull request #2489 from RyeMutt/fix-buffervis

    Fix visualizing luminance buffer and small cleanup

commit dfae0d9d782d172d892d1823584178d7a26b0624
Author: Rye Cogtail <rye@lindenlab.com>
Date:   Tue Sep 3 17:55:17 2024 -0400

    Fix visualizing luminance buffer and small cleanup

commit ceed015e4e23e421197b47f9e6f16c9835ec080a
Merge: 821a7314b1 e42e95d878
Author: cosmic-linden <111533034+cosmic-linden@users.noreply.github.com>
Date:   Tue Sep 3 13:56:00 2024 -0700

    Merge pull request #2484 from secondlife/v-2483

    secondlife/viewer#2483: Fix label typo in PBR terrain texture transforms tab

commit e42e95d87896fa3be0b48108dc3b79af2e1caf66
Author: Cosmic Linden <cosmic@lindenlab.com>
Date:   Tue Sep 3 10:05:44 2024 -0700

    secondlife/viewer#2483: Fix label typo in PBR terrain texture transforms tab

commit 821a7314b13127d0896fe0ba59ac3567b58245cc
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Tue Sep 3 12:55:59 2024 +0300

    viewer#2311 Message about oversized snapshots wasn't shown in some cases

commit fc46e6147ee3d0304793188e3fbf4c2a7854ecfa
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Tue Sep 3 08:16:22 2024 +0300

    viewer#2310 Fix snapshot's size string dropping color during upload

commit ee9f7ec670c4c94f871f7abed68a573b844a69a6
Author: Alexander Gavriliuk <alexandrgproductengine@lindenlab.com>
Date:   Tue Sep 3 00:55:55 2024 +0200

    #2403 Reset Skeleton issues

commit 470f35b10937ff649b50fcacff4fe40a9c0e52de
Author: Alexander Gavriliuk <alexandrgproductengine@lindenlab.com>
Date:   Mon Sep 2 18:22:54 2024 +0200

    #2471 The Destinations ComboBox on Login Screen changes the selected item to the similar one

commit 12d60b3d9b15adc1d6a04eaacd65c71829b73c38
Author: TJ <tj8@live.com.au>
Date:   Tue Sep 3 05:51:58 2024 +1000

    More styling fixes and other minor inconsistency fixes in inventorymodelbackgroundfetch code. (#2476)

commit 7c9c142a55f46351e9bc3dace9c2753fee6ed3c9
Author: Brad Linden <46733234+brad-linden@users.noreply.github.com>
Date:   Sun Sep 1 11:05:48 2024 -0700

    Restore old error handling early out logic in LLAppViewer::init() (#2475)

    fixes secondlife/viewer#2474

commit 5b832291a8ea1f100e2caaffef3d162dd96bee50
Author: Rye Mutt <rye@lindenlab.com>
Date:   Fri Aug 30 12:49:05 2024 -0700

    Introduce Khronos Neutral tonemapper as new default along with debug options to control tonemap mix (#2464) (#2468)

commit 7ab6144c0046338053019283f1f1ed75575b3496
Merge: 89a45ef1cb 9004cf64bf
Author: cosmic-linden <111533034+cosmic-linden@users.noreply.github.com>
Date:   Fri Aug 30 11:05:44 2024 -0700

    Merge pull request #2472 from secondlife/v-2448

    secondlife/viewer#2448: Fix crash rendering rigged PBR prims

commit 9004cf64bf5066a778eea39a4ab48623b04c6d42
Author: Cosmic Linden <cosmic@lindenlab.com>
Date:   Fri Aug 30 10:57:44 2024 -0700

    secondlife/viewer#2448: Fix crash rendering rigged PBR prims

commit 89a45ef1cba9969b844d82da6ff2a751a5c35ef1
Author: Ansariel Hiller <Ansariel@users.noreply.github.com>
Date:   Fri Aug 30 19:17:36 2024 +0200

    Fix background folder fetch pushing requests to wrong queue (#2436)

commit 60142c1b2fa7961d6dbf9744ad1b5c78f956d7f5
Author: AiraYumi <aira.youme@airanyumi.net>
Date:   Fri Aug 30 23:35:19 2024 +0900

    update OpenJPEG 2.5.2 (#2452)

commit 400c21213acb050b653247f295975b9ab35b62ad
Author: Alexander Gavriliuk <alexandrgproductengine@lindenlab.com>
Date:   Fri Aug 30 00:48:02 2024 +0200

    #2454 Scrolling by the mouse wheel does not scroll up on the unopened Destination field

commit 7e58f089a808b9622f6604407934b36650844a04
Merge: 17fed3985f 9c6988cf22
Author: Rye Mutt <rye@lindenlab.com>
Date:   Thu Aug 29 16:29:36 2024 -0700

    Merge pull request #2466 from RyeMutt/smaa

    Introduce SMAA and rework post process chain for better visual quality

commit 17fed3985f56033f6c433436935cfde32ea1e7c6
Author: Alexander Gavriliuk <alexandrgproductengine@lindenlab.com>
Date:   Thu Aug 29 15:43:01 2024 +0200

    #2360 Incorrect Day Cycle name in Edit Day Cycle floater (remove unused key CANMOD)

commit 9c6988cf2282a02c5dae31dcada147240ead4e64
Author: Rye Mutt <rye@alchemyviewer.org>
Date:   Thu Aug 29 18:03:46 2024 -0400

    Fix startup crash from removed setting

commit 958afaa7a7bfb1217bbffee3fe562f21901277ac
Author: Rye Mutt <rye@alchemyviewer.org>
Date:   Tue Aug 27 22:47:32 2024 -0400

    Integrate SMAA and rework post process chain for better visual quality
    Add SMAA buffer generation passes
    Add quality levels for both FXAA and SMAA
    Separate gamma correction and tonemapping for effects that require linear-but-tonemapped inputs
    Move application of noise to final render pass to screen to avoid damaging other post process effects

commit ecf3002a4623ebed0ed31bcc11f743000deeac84
Merge: e2809755c5 b0fefd62ad
Author: Brad Linden <brad@lindenlab.com>
Date:   Thu Aug 29 13:32:34 2024 -0700

    Merge remote-tracking branch 'origin/release/2024.08-DeltaFPS' into develop

commit 3a7374892945a233a9eaa3a88c94a984873373d3
Author: Rye Mutt <rye@alchemyviewer.org>
Date:   Thu Aug 29 15:56:28 2024 -0400

    Remove dead texunit colorspace conversion code

commit 8759edd575bf34798237f559a4a515ce76a7b7d0
Author: Rye Mutt <rye@alchemyviewer.org>
Date:   Thu Aug 29 15:55:19 2024 -0400

    Fix SSR clamping hdr brightness ranges

commit b0fefd62adbf51f32434ba077e9f52d8a9241d15
Author: Dave Parks <davep@lindenlab.com>
Date:   Thu Aug 29 15:06:24 2024 -0500

    #2428 Fix for crash when applying PBR material to a single face (take 2) (#2463)

    Also fix for some objects randomly disappearing until they're selected again.

commit 11afd7f86afd19fde8b577f57736d6d27542484e
Author: Brad Linden <46733234+brad-linden@users.noreply.github.com>
Date:   Thu Aug 29 12:57:49 2024 -0700

    Add error handling for intel crashes from GLTF Scene shader (#2456)

    fix secondlife/viewer#1856

commit e2809755c5e4a6a6d3c8f27911865efe4020d679
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Thu Aug 22 17:27:16 2024 +0300

    Make LLPipeline::renderDebug() a bit cheaper

    Each frame renderDebug() was pointlesly going over a large list of
    partitions and bridges.

commit 0b062be30862e645bb9a660067f9783d63e2fa34
Merge: e26261c7f9 f23f28c8f9
Author: cosmic-linden <111533034+cosmic-linden@users.noreply.github.com>
Date:   Thu Aug 29 09:10:46 2024 -0700

    Merge pull request #2449 from secondlife/v-2421

    secondlife/viewer#2421: Do not calculate and store silhouette edges for nearly every geometric prim with a corner

commit e26261c7f936d697a96b964723498f3e989017d8
Author: Alexander Gavriliuk <alexandrgproductengine@lindenlab.com>
Date:   Wed Aug 28 23:51:29 2024 +0200

    #2360 Incorrect Day Cycle name in Edit Day Cycle floater after clicking the "Customize" button

commit f15228023f3a1094f69891a5f431cff3d895515a
Author: Brad Linden <46733234+brad-linden@users.noreply.github.com>
Date:   Wed Aug 28 16:20:25 2024 -0700

    Attempt to get better file/line info for LL_ERRS crahses in bugsplat. (#2447)

    secondlife/viewer#2445

commit f23f28c8f9ccc36e8f70beb63b58b3114246a09c
Author: Cosmic Linden <cosmic@lindenlab.com>
Date:   Wed Aug 28 15:59:03 2024 -0700

    secondlife/viewer#2421: Do not calculate and store silhouette edges for nearly every geometric prim with a corner

commit e92a06d68114c933599da12d75221504ebac77e0
Merge: f8d48f6a29 b281020b81
Author: Maxim Nikolenko <maximnproductengine@lindenlab.com>
Date:   Thu Aug 29 02:12:40 2024 +0300

    Merge pull request #2440 from secondlife/develop-clear-metrics

    Clear unused metrics

commit f8d48f6a29f312724b826806fdc2f9b5ed85fd13
Author: Dave Parks <davep@lindenlab.com>
Date:   Wed Aug 28 14:49:13 2024 -0500

    #2432 Restore default nametag behavior. (#2444)

    After instrumenting nametags some more, really UI rendering performance improvements should just focus on LLFontGL::render

commit 6a4d7b2de622503e00ff58de6a2fc7742ff4df21
Merge: 9d689c6145 1f58884db9
Author: cosmic-linden <111533034+cosmic-linden@users.noreply.github.com>
Date:   Wed Aug 28 11:37:56 2024 -0700

    Merge pull request #2441 from secondlife/2438-eliminate-execution-time-outliers-for-updateimagedecodepriority

    #2438 Address frame stalls in updateImageDecodePriority

commit 1f58884db9c026c1a74f693fc84e37a2f66830e3
Author: RunitaiLinden <davep@lindenlab.com>
Date:   Wed Aug 28 13:14:58 2024 -0500

    #2438 Address frame stalls in updateImageDecodePriority

commit b281020b8150952f41f9424427d6bff76aa10126
Author: Mnikolenko Productengine <mnikolenko@productengine.com>
Date:   Wed Aug 28 19:51:00 2024 +0300

    Clear unused metrics

commit 9d689c6145cefcc86b228462279859dfb726429d
Merge: 5c16ae1375 00acf4fdb7
Author: Dave Parks <davep@lindenlab.com>
Date:   Wed Aug 28 10:57:53 2024 -0500

    Merge pull request #2435 from secondlife/2432-default-nametags-to-only-show-briefly

    #2432 default nametags to only show briefly and #2431 fix redundant search for pixiesmall.j2c

commit 00acf4fdb7e953726240f76f8b5103c82e0ce692
Author: RunitaiLinden <davep@lindenlab.com>
Date:   Tue Aug 27 16:32:28 2024 -0500

    #2432 Make nametags default to "show briefly"

commit feecf0957302b3bd7f6eb3e0908f95a39dd51f43
Author: RunitaiLinden <davep@lindenlab.com>
Date:   Tue Aug 27 15:59:41 2024 -0500

    #2431 Fix for redundant searching for pixeismall.j2c causing frame stalls

commit 8406d1052c70d1d9f964ec86f6f5468aa9f57bb1
Author: Dave Parks <davep@lindenlab.com>
Date:   Tue Aug 27 11:53:54 2024 -0500

    #2428 Fix for crash when applying PBR material (#2430)

    Also attempt to fix some occasional bad texture memory tracking.

commit 5c16ae13758bdfe8fe1f13d5f67eabbb6eaa30a1
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Tue Aug 27 12:02:41 2024 +0300

    viewer#2413 Remove obsolete alert about expiring voice morphs

commit 124f0711afd504847f3c4cc96f1f5c000f7f58b0
Merge: 39c7f149e4 50dc4cbdf9
Author: Brad Linden <brad@lindenlab.com>
Date:   Mon Aug 26 17:28:34 2024 -0700

    Merge remote-tracking branch 'origin/release/2024.08-DeltaFPS' into develop

commit 50dc4cbdf9640601ca164086bee4f3a7b91868ca
Merge: 367c8f2363 35efadf783
Author: Brad Linden <brad@lindenlab.com>
Date:   Mon Aug 26 17:25:13 2024 -0700

    Merge remote-tracking branch 'origin/main' into release/2024.08-DeltaFPS

commit 367c8f2363cebbcd6c37484d15e0863612bcc1c9
Author: Brad Linden <46733234+brad-linden@users.noreply.github.com>
Date:   Mon Aug 26 17:24:07 2024 -0700

    Improve safety of macOS available RAM calcuations at suggestion of Ansariel and Beq (#2423)

commit 600ec6fcdac5ae8868759512ba8c0a304ad8738f
Merge: e5fd6854ae 316f0f0b8c
Author: cosmic-linden <111533034+cosmic-linden@users.noreply.github.com>
Date:   Mon Aug 26 17:14:50 2024 -0700

    Merge pull request #2424 from secondlife/brad/cherry-picks-hot-logging

    Fast track some changes removing unneeded logging code into DeltaFPS

commit 316f0f0b8cb05515068e2acb72740fbab2365ce0
Author: Cosmic Linden <cosmic@lindenlab.com>
Date:   Thu Aug 22 09:11:28 2024 -0700

    secondlife/viewer#2391: Remove avatar rigging "callstack" logging

commit ef916bd3ae39fb6fd718428aa2a695bbea891940
Author: Rye Mutt <rye@alchemyviewer.org>
Date:   Thu Aug 22 00:43:50 2024 -0400

    Remove or suppress left over debug messages in hot paths (#2392)

commit e5fd6854aedb620825ffcd079c5bb3aa1c90b134
Merge: 0edf6e230e e23f2f1cf7
Author: Brad Linden <46733234+brad-linden@users.noreply.github.com>
Date:   Mon Aug 26 16:04:30 2024 -0700

    Merge pull request #2422 from secondlife/brad/2395-fix-start-location

    Fix start location dropping coordinates on login

commit e23f2f1cf7c5a3b34d1635c490e5c8871a4d9d5c
Author: Brad Linden <brad@lindenlab.com>
Date:   Mon Aug 26 15:01:04 2024 -0700

    defensively capture coroutine args by value

commit 3e2866f876696b149cee248e1e9bf5343dff0de6
Author: Brad Linden <brad@lindenlab.com>
Date:   Mon Aug 26 14:49:11 2024 -0700

    secondlife/viewer#2395 fix start location coordinates getting double escaped

commit 39c7f149e4d38232469473b0275028485493b4ec
Merge: 17f515cd3e ca115671d6
Author: Rye Mutt <rye@lindenlab.com>
Date:   Mon Aug 26 14:37:06 2024 -0700

    Merge pull request #2415 from RyeMutt/add-cas

    Introduce Contrast Adaptive Sharpening post process effect

commit 35efadf78315f9b351415930dca4fae251ef4dd0
Author: Nat Goodspeed <nat@lindenlab.com>
Date:   Mon Aug 26 16:12:31 2024 -0400

    Increment viewer version to 7.1.10
    following promotion of secondlife/viewer #1829: 2024.06 Atlasaurus

commit ca115671d6310798ac512a9a6baa71a06f14e9ce
Author: Rye Mutt <rye@alchemyviewer.org>
Date:   Mon Aug 26 15:42:57 2024 -0400

    Replaced refreshCachedSetting for sharpening with cached control

commit 779e195d1c8b39d31e5e3ed995e076fa4f6c943a
Merge: 436e986893 17f515cd3e
Author: Dave Parks <davep@lindenlab.com>
Date:   Mon Aug 26 09:08:13 2024 -0500

    Merge branch 'develop' into add-cas

commit 436e986893d6eb9de1c4531540e6e2afe8ec06cb
Author: Rye Cogtail <rye@lindenlab.com>
Date:   Fri Aug 23 22:05:34 2024 -0400

    Fix mac crash on startup due to missing types from enum

commit 2ca193ce468cd4420e0ed47a7991661d1b1ca635
Author: Rye Cogtail <rye@lindenlab.com>
Date:   Fri Aug 23 22:06:28 2024 -0400

    Improve FXAA quality and performance when GL version is greater then 4
    Adds gather4 support under GLSL 4.0+

commit cbca17825614d18a96994c94ec0c38e9d8e812cf
Author: Rye Mutt <rye@alchemyviewer.org>
Date:   Sat Aug 24 00:55:32 2024 -0400

    Add Contrast Adaptive Sharpening post process effect(#2399)

commit 17f515cd3e4239d3c6e1958d998e455a8300da90
Author: TommyTheTerrible <81168766+TommyTheTerrible@users.noreply.github.com>
Date:   Sat Aug 24 00:21:03 2024 -0400

    Update LLImageJ2C::calcDataSizeJ2C for better 2k image support (#2406)

    Adjusted calculations based on dimensions and assumed maximum block size so that higher discards (4-5) of 2048x2048 images can be decoded with aux/alpha.

    (It should also work for dimensions larger than 2048.)

    This function will now return a reliable discard 5 data size for unknown dimensions (w and/or h equals 0), which could be used in LLTextureFetch::createRequest to skip the header fetch and go right to a discard 5 decode.

    Tested on OpenJPEG 2.5 with partial decode support (opj_decoder_set_strict_mode set to false).

    Should work on KDU fine but might be a good idea to test.

commit 0edf6e230e4580fc61917bc823f82d983d807ccf
Author: Dave Parks <davep@lindenlab.com>
Date:   Fri Aug 23 16:35:52 2024 -0500

    #2388 Texture downrezzing tune up. (#2414)

    - Hold onto unreferenced textures for 30 seconds.
    - Don't downres unless memory is low
    - Downres when viewer is backgrounded.

commit 45b2d69446a68f5b104bd61055214d17da920fae
Author: Rye Mutt <rye@lindenlab.com>
Date:   Fri Aug 23 11:50:20 2024 -0700

    Add dedicated sun probe shader and remove SSAO and shadow smoothing from probe generation passes (#2405)

    * Add dedicated sun probe shader and remove SSAO and shadow smoothing from probe generation passes (#2398)

    * Fix usage of removed sunLightNoFragCoordV in shader manager

commit efe8783d6bb054754033161c18948bf1cb7e206d
Merge: 8a22c311c8 552d1d421b
Author: Vir Linden <60274682+vir-linden@users.noreply.github.com>
Date:   Fri Aug 23 09:42:50 2024 -0400

    Merge pull request #2368 from secondlife/andreyk/viewer_2363

    viewer#2363 Region Day Offset error with Time of Day

commit 8a22c311c8746b68a0baba98a6ab8bd578536d6c
Merge: 421ee5107f 1adf2d00eb
Author: Brad Linden <brad@lindenlab.com>
Date:   Thu Aug 22 15:48:37 2024 -0700

    Merge remote-tracking branch 'origin/release/2024.08-DeltaFPS' into develop

commit 1adf2d00ebd340dca72532585276279cb6911dfb
Author: Brad Linden <brad@lindenlab.com>
Date:   Thu Aug 22 15:46:48 2024 -0700

    Fix usage of $branch before it was initialized in build.

commit 421ee5107f6f795b89c48b068d549022b05eba60
Merge: 2c4fe4ff45 fc7082e93d
Author: Brad Linden <brad@lindenlab.com>
Date:   Thu Aug 22 14:07:34 2024 -0700

    Merge remote-tracking branch 'origin/release/2024.08-DeltaFPS' into develop

commit fc7082e93dde7ea122e7f0782f66e0aeb530596f
Merge: c2402afd8b 25c4ba3a76
Author: Brad Linden <brad@lindenlab.com>
Date:   Thu Aug 22 14:06:07 2024 -0700

    Merge remote-tracking branch 'origin/release/2024.06-atlasaurus' into release/2024.08-DeltaFPS

commit 25c4ba3a76c3dd81bb9554abf27ab3cbe5dcd95d
Author: Dave Parks <davep@lindenlab.com>
Date:   Thu Aug 22 15:59:22 2024 -0500

    #2397 Sanity clamp haze contribution to avoid NaN like blowouts. (#2402)

commit 2c4fe4ff454490454d0bb71c1e5359747524048a
Author: cosmic-linden <111533034+cosmic-linden@users.noreply.github.com>
Date:   Thu Aug 22 11:45:14 2024 -0700

    secondlife/viewer#2349: Avatar/animesh rendering correctness pass (#2364)

    * secondlife/viewer#2349: Blinn-Phong avatar/animesh rendering optimization/correctness pass
    * secondlife/viewer#2349: General avatar/animesh rendering optimization/correctness pass

commit c2402afd8b681879bdc5fe563364f5842da31992
Merge: a0da63db57 33c7a879c1
Author: Brad Linden <brad@lindenlab.com>
Date:   Thu Aug 22 11:15:11 2024 -0700

    Merge remote-tracking branch 'origin/release/2024.06-atlasaurus' into release/2024.08-DeltaFPS

     # Conflicts:
     #	indra/newview/featuretable_mac.txt

commit 9b0010b5d5a00eb59b71487701b98b50992f8a8e
Author: Brad Linden <46733234+brad-linden@users.noreply.github.com>
Date:   Thu Aug 22 10:56:20 2024 -0700

    Incremented viewer version after release/2024.08-DeltaFPS branch creation (#2369)

commit 31d0d6669c91eddb9f0a0f524db2aa54a30eb751
Merge: 1cc1872c76 1743fe92d6
Author: cosmic-linden <111533034+cosmic-linden@users.noreply.github.com>
Date:   Thu Aug 22 10:13:50 2024 -0700

    Merge pull request #2396 from secondlife/v-2391

    secondlife/viewer#2391: Remove avatar rigging logging due to load time impact

commit 1cc1872c76de0d5f5d6c04c4b510367f9f002d97
Author: Alexander Gavriliuk <alexandrgproductengine@lindenlab.com>
Date:   Thu Aug 22 15:59:15 2024 +0200

    #2393 BugSplat Crash #1504586: LLRenderTarget::getTexture(483)

commit 1743fe92d6c6ed2615d3336ab86062fbe845c1be
Author: Cosmic Linden <cosmic@lindenlab.com>
Date:   Thu Aug 22 09:11:28 2024 -0700

    secondlife/viewer#2391: Remove avatar rigging "callstack" logging

commit 28331b2385a8de2a0fde67329127c1694e3f219f
Author: Rye Mutt <rye@alchemyviewer.org>
Date:   Thu Aug 22 11:25:25 2024 -0400

    Do deprecated texture swizzle on GPU using GL texture swizzling functions (#2389)

    * Use GL texture swizzling instead of scratch buffer for deprecated formats when GL 3.3 is available
    Fix crash when GL texture compression is enabled

    * Fix UI font atlas being eligible for texture compression

commit f7bb097247e5ccbd699a76e872913e557c545d3a
Author: Alexander Gavriliuk <alexandrgproductengine@lindenlab.com>
Date:   Wed Aug 21 18:04:28 2024 +0200

    #2325 WebRTC: p2p voice calling option sometimes becomes disabled after calling another agent back too soon

commit 8fef55b3b22678729d7dbd07933c0600ec7f4db8
Author: Rye Mutt <rye@alchemyviewer.org>
Date:   Thu Aug 22 00:43:50 2024 -0400

    Remove or suppress left over debug messages in hot paths (#2392)

commit 0e59ed204fdf84c5323837e5c91cfa7da0a9e89b
Author: Dave Parks <davep@lindenlab.com>
Date:   Wed Aug 21 14:36:18 2024 -0500

    Fix crash on Intel GPUs (or anywhere OpenGL compatibility profile is used). (#2387)

commit 33c7a879c1762895e4ab353f0fecc223640f89ec
Author: Brad Linden <46733234+brad-linden@users.noreply.github.com>
Date:   Wed Aug 21 12:02:21 2024 -0700

    Bump featuretable versions to fix secondlife/viewer#2345 (#2386)

    also fixed mac High entry for RenderMirrors that got missed

commit 27fa9b81385b2cdce2c4c26cd0c069ccb4d4bc82
Merge: 738b39fbab 7b1d1852c2
Author: Brad Linden <46733234+brad-linden@users.noreply.github.com>
Date:   Wed Aug 21 09:49:54 2024 -0700

    Merge pull request #2372 from secondlife/roxie/webrtc-fix-mac-p2p-hang

    Fix hang when incoming p2p or group calls throw up dialog.

commit 4bda6873ee7baac1ac34f92178d871c430da88c6
Author: Ansariel Hiller <Ansariel@users.noreply.github.com>
Date:   Wed Aug 21 18:46:49 2024 +0200

    More changes to Clang-Format to match the current coding standard (#2375)

commit 40e93e9f4d9059a298e16009483cf531eccd7c82
Author: Ansariel <ansariel.hiller@phoenixviewer.com>
Date:   Wed Aug 21 14:15:07 2024 +0200

    Fix formatting and add some more constexpr

commit db84bf9567c27e266ccc6b1b6aed089c6022fe91
Author: Rye Mutt <rye@alchemyviewer.org>
Date:   Wed Aug 21 10:47:31 2024 -0400

    Improve accuracy of texture memory tracking (#2371)

    * Fix alloc_tex_image to account for more missing texture memory
    Change alloc_tex_image calls to pass internal format to properly account for used image type

    * Fix scaleDown passing primary format in place of internal format to glTexImage2D

    * Make texture debug view and texture bias calculation consistent and remove double accounting for render target textures

commit 7b1d1852c291a9c092961c2f51f0160e0e7da1e6
Merge: 7560bd0be2 738b39fbab
Author: Roxie Linden <roxie@lindenlab.com>
Date:   Tue Aug 20 17:17:16 2024 -0700

    Merge branch 'release/2024.06-atlasaurus' of github.com:secondlife/viewer into roxie/webrtc-fix-mac-p2p-hang

commit 7560bd0be2c4fbbe9bd9d3b218704229573fb5bc
Author: Roxie Linden <roxie@lindenlab.com>
Date:   Tue Aug 20 17:14:00 2024 -0700

    removed unnecessary comment

commit 45ebc5867a745dd4a746694317d715cbcead0871
Author: Roxie Linden <roxie@lindenlab.com>
Date:   Tue Aug 20 15:34:20 2024 -0700

    Fix hang when incoming p2p or group calls throw up dialog.

    There were changes in atlasaurus that resulted in a hang for incoming p2p
    and group calls which throw up dialogs.  The changes revolved around mutex,
    coroutines, job queues, and such.
    The fix was to do any processing that may result in callbacks from
    the webrtc code in a queued job instead of a coroutine.

commit 738b39fbab2b46b2085c220be7bbced0d43fb823
Merge: 1d017b7629 56e1687680
Author: Brad Linden <46733234+brad-linden@users.noreply.github.com>
Date:   Tue Aug 20 14:55:59 2024 -0700

    Merge pull request #2370 from secondlife/geenz/fix/increment-featuretable

    #2345 Fix for mirrors not being disabled from previous viewer versions.

commit 56e16876805c80f63a70024e00b5dfcc5e4e45d7
Author: Jonathan "Geenz" Goodman <geenz@geenzo.com>
Date:   Tue Aug 20 14:05:40 2024 -0700

    #2345 Fix for mirrors not being disabled from previous viewer versions.

commit 552d1d421b4c67dfdf3fe14316116b34b54e97d7
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Tue Aug 20 23:23:55 2024 +0300

    viewer#2363 Region Day Offset error with Time of Day

    When we have a 23h day cycle and 23h offset, doing a 24h flip will
    result in -1h. Flip by day length instead so that 23h-23h will result
    in 0h.

    This has a negative side effect of values not being saved exactly as
    users specified them, so a -1h offset will turn to 4h on next load
    with a 5h long day. But it is nature of a day to 'loop', so I decided
    there is no point to translate -1 into 14 or something like that.

# Conflicts:
#	indra/newview/skins/default/xui/ja/language_settings.xml
#	indra/newview/skins/default/xui/ja/notifications.xml
@brad-linden brad-linden modified the milestones: Develop, 2024.09-ExtraFPS Sep 19, 2024
@vladyslavasproductengine

Passed QA.

Verified on the Second Life Release 7.1.11.10947335521 (64bit) on Win10/OSX in the scope of https://github.com/secondlife/iqa/issues/348.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working team:viewer
Projects
None yet
5 participants