Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PBR scale and offset crosshair work like Texture crosshair do #1922

Closed
akleshchev opened this issue Jul 3, 2024 · 7 comments · Fixed by #2215, #2220, #2224 or #2189
Closed

Make PBR scale and offset crosshair work like Texture crosshair do #1922

akleshchev opened this issue Jul 3, 2024 · 7 comments · Fixed by #2215, #2220, #2224 or #2189
Labels
enhancement New feature or request team:viewer

Comments

@akleshchev
Copy link
Contributor

akleshchev commented Jul 3, 2024

Note white crosshair on the image, it shows texture's center for textures yet face's center for PBR.

I think they should be identical, PBR should be showing 4 markers, not 1. Texture vs PBR:
Screenshot 2024-07-03 at 17 49 14
Screenshot 2024-07-03 at 17 50 54

Test Plan

  • Set two cubes side by side
  • Switch build tools to 'select face'
  • Open texture tab and assign a pbr to one of the cubes (Material->'PBR Material roughtness' then click the image)
  • Change scale U and V (or vertical and horizontal in texture tab) for both cubes to 2.
@akleshchev akleshchev added enhancement New feature or request triage Flags issues that need to be triaged labels Jul 3, 2024
@KrsityKu
Copy link

KrsityKu commented Jul 3, 2024

There was Canny about this https://feedback.secondlife.com/scripting-features/p/make-texture-offsets-work-the-same-way-for-phong-and-pbr-textures

And my thinking was:

I believe the glTF standard specifies that the textures need to be mapped this way so they either have to make it not conform to the standard, making glTF compatible imports not compatible, or change legacy materials to match, breaking all existing content.

Thought it would be nice to hear from the dev team if that is actually the case, as that canny was closed without elaborating on it.

@akleshchev
Copy link
Contributor Author

akleshchev commented Jul 3, 2024

I'm not suggesting to make texture offset work similarly, I'm suggesting to fix markers and borders. The white round with a cross in the middle should be in the middle of an offsetted par, not in the middle of the object and should properly highlight where texture ends.

@akleshchev
Copy link
Contributor Author

akleshchev commented Jul 3, 2024

Here is a better example:
Screenshot 2024-07-03 at 19 32 17
Screenshot 2024-07-03 at 19 32 33
There should have been 4 markers, not 1.

@KrsityKu
Copy link

KrsityKu commented Jul 3, 2024

I'm not suggesting to make texture offset work similarly, I'm suggesting to fix markers and borders.

Oh, my bad.

@akleshchev akleshchev added team:viewer and removed triage Flags issues that need to be triaged labels Jul 11, 2024
@akleshchev akleshchev changed the title Make PBR scale and offset markers work like Texture markers do Make PBR scale and offset crosshair work like Texture markers do Jul 12, 2024
Copy link

canny bot commented Jul 12, 2024

@akleshchev akleshchev changed the title Make PBR scale and offset crosshair work like Texture markers do Make PBR scale and offset crosshair work like Texture crosshair do Jul 12, 2024
@AtlasLinden AtlasLinden added this to the Develop milestone Jul 17, 2024
@LLGuru LLGuru self-assigned this Jul 24, 2024
@akleshchev akleshchev reopened this Aug 7, 2024
LLGuru added a commit that referenced this issue Aug 7, 2024
LLGuru added a commit that referenced this issue Aug 7, 2024
@akleshchev akleshchev reopened this Aug 7, 2024
@akleshchev akleshchev reopened this Aug 7, 2024
@LLGuru LLGuru removed their assignment Aug 8, 2024
@akleshchev akleshchev reopened this Aug 8, 2024
@brad-linden brad-linden modified the milestones: Develop, 2024.08-DeltaFPS Aug 22, 2024
@sergiiiproductengine
Copy link

sergiiiproductengine commented Aug 28, 2024

Win10/Win11: Passed QA.

OSX: Deferred QA.
The issue cannot be verified on the OSX due to new #2437 issue.

The ticket status has not been changed yet.

Also, the new #2428 issue was created during verification this ticket.

@igorlproductengine
Copy link

Passed QA.

Verified on the Second Life Release 7.1.10.10708851543 (64bit) on Win10/OSX in the scope of https://github.com/secondlife/iqa/issues/326.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment