-
Notifications
You must be signed in to change notification settings - Fork 54
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
SL-18721 Viewer shutdown order changes
Same thing as commit cf692c4 which was removed due to shutdown freezes. Error thread is no longer there so doesn't cause any race sonditions, was not able to repro any issues so will ask QA to test shutdown
- Loading branch information
1 parent
858cde0
commit edf0874
Showing
3 changed files
with
14 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edf0874
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bad news: This again randomly results in a deadlock during shutdown. The main thread is waiting on one thread to finish (threadpool.cpp line 81), while I have a bunch of threads which are waiting to get unblocked via their mutex (llthread.cpp line 343). All of these threads are related to the texture pipeline.
edf0874
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the info. Our tools did register an uptick of shutdown freezes but I was not able to repro, will see if I can figure it out.
edf0874
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't see anything wrong with this... Unfortunately will have to roll it back and think of an alternate solution, may be a tiny winow (like the one on startup) that says ''saving please wait"