Skip to content

Commit

Permalink
Update emoji_categories in Polish translation to slightly more correc…
Browse files Browse the repository at this point in the history 
…t erms...
  • Loading branch information
@PanteraPolnocy @akleshchev
PanteraPolnocy authored and akleshchev committed Mar 1, 2024
1 parent fe3be58 commit 60debe8
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions indra/newview/skins/default/xui/pl/emoji_categories.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@
<key>Name</key>
<string>smileys and emotion</string>
<key>Category</key>
<string>buźki and emocje</string>
<string>buźki i emocje</string>
</map>
<map>
<key>Name</key>
<string>people and body</string>
<key>Category</key>
<string>ludzie and ciało</string>
<string>ludzie i ciało</string>
</map>
<map>
<key>Name</key>
Expand All @@ -23,7 +23,7 @@
<key>Name</key>
<string>animals and nature</string>
<key>Category</key>
<string>zwierzęta and przyroda</string>
<string>zwierzęta i przyroda</string>
</map>
<map>
<key>Name</key>
Expand All @@ -35,19 +35,19 @@
<key>Name</key>
<string>travel and places</string>
<key>Category</key>
<string>podróże and miejsca</string>
<string>podróże i miejsca</string>
</map>
<map>
<key>Name</key>
<string>activities</string>
<key>Category</key>
<string>aktywność</string>
<string>aktywności</string>
</map>
<map>
<key>Name</key>
<string>objects</string>
<key>Category</key>
<string>objekt</string>
<string>obiekty</string>
</map>
<map>
<key>Name</key>
Expand Down

3 comments on commit 60debe8

@Ansariel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually breaking the emoji category and group display in the emoji picker entirely. The localized strings are being referenced in the emoji character table inside the emoji_shortcodes 3p. So if you want to fix the localization, you not just have to do it here, but also update the emoji_shortcodes 3p. If you think this is bad design, then you are 100% correct! 😂

@akleshchev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing that out, that's indeed bad design, picked that jira and will try to solve it some time soon

P.S I thought it was fixed, but looks like it fell trough jira->github transition cracks.

@akleshchev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a mess... I'm probably going to start by replacing ' and ' in emoji_shortcodes with ' & ' to not mix locales with an english 'and'.
Not sure what to do about emoji_categories.xml. May be I will just use 'en' locale for filling groups in emoji_shortcodes so that there wouln't be a need to match values by localized 'category" and only match by "name". Or may be will use those in parralel... would be ideal if there is some kind of group id, still looking into that.

Please sign in to comment.