Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micro-optimize NamePrettifier::prettifyTestMethodName() #5739

Closed
wants to merge 1 commit into from

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Mar 12, 2024

the function call is showing up in blackfire profiles of blackfire run php ./phpunit --testsuite unit

grafik

after the change it no longer appears

@sebastianbergmann sebastianbergmann added type/performance Issues related to resource consumption (time and memory) version/10 Something affects PHPUnit 10 version/11 Something affects PHPUnit 11 labels Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.01%. Comparing base (dede51b) to head (862a43d).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5739   +/-   ##
=========================================
  Coverage     90.01%   90.01%           
  Complexity     6493     6493           
=========================================
  Files           688      688           
  Lines         19714    19715    +1     
=========================================
+ Hits          17745    17746    +1     
  Misses         1969     1969           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastianbergmann
Copy link
Owner

Cherry-picked into 10.5 and merged to 11.0 and main from there. Thanks!

@staabm staabm deleted the micro branch March 12, 2024 07:02
@sebastianbergmann sebastianbergmann added the feature/testdox The TextDox printer/formatter label Mar 12, 2024
@sebastianbergmann sebastianbergmann changed the title Micro optimize NamePrettifier->prettifyTestMethodName() Micro-optimize NamePrettifier::prettifyTestMethodName() Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/testdox The TextDox printer/formatter type/performance Issues related to resource consumption (time and memory) version/10 Something affects PHPUnit 10 version/11 Something affects PHPUnit 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants