Support for multiple arguments

[joke2k]

This work adds the support for providing multiple files or directories as arguments to PHPUnit:

./phpunit FooTest.php test/

It is very useful when you want to test multiple things together without having a Suite defined in the configuration, and most important (for me) is that it works for CircleCI's parallelisation command (apparently phpunit is one of the few test frameworks without this feature).

It could be easily extended for phpunit9.

Point to discuss

• naming the Test suite: a proposal is using a hash (md5) of all provided arguments (the list could be very long)

[sebastianbergmann]

It could be easily extended for phpunit9.

PHPUnit 9 is closed for changes other than bug fixes and adaptions to new versions of PHP.

[codecov]

Codecov Report

Merging #5462 (7305a82) into main (d0103c0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 7305a82 differs from pull request most recent head ba75b2a. Consider uploading reports for the commit ba75b2a to get more accurate results

@@             Coverage Diff              @@
##               main    #5462      +/-   ##
============================================
+ Coverage     87.06%   87.07%   +0.01%     
- Complexity     6205     6211       +6     
============================================
  Files           662      662              
  Lines         19858    19874      +16     
============================================
+ Hits          17290    17306      +16     
  Misses         2568     2568              

Files Changed	Coverage Δ
src/TextUI/Configuration/TestSuiteBuilder.php	100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[joke2k]

Thank you for the reply and to take into consideration this work.

I applied the CSFixer rules, sorry about that.

I was wondering how to tell to psalm that $configuration->cliArgument() cannot raise a NoCliArgumentException in the TestSuiteBuilder::build because a few lines above $configuration->hasCliArgument() has been checked.

I tried several solutions to avoid that MissingThrowsDocblock, but I'm not able to fix it yet even if I add @throws NoCliArgumentException to the method, which is not true.
Seems that psalm forgets the @psalm-assert-if-true !null $this->cliArgument on the Configuration::hasCliArgument.

I don't understand why this issue didn't appear before my changes

[joke2k]

@sebastianbergmann do you have any ideas on how to satisfy psalm in this case?

[sebastianbergmann]

I do not have time to look into this right now.

[joke2k]

@sebastianbergmann this is ready to be checked again. psalm issue should be fixed.

Thank you

[sebastianbergmann]

Please do not use the ternary operator here.

[joke2k]

splitted using a more readable if-else.

[sebastianbergmann]

naming the Test suite: a proposal is using a hash (md5) of all provided arguments (the list could be very long)

As of 51f93ba, the name of the top-level test suite that is created when a directory or file path is passed as an argument to the test runner is now always CLI Arguments.

[sebastianbergmann]

Thank you for patience. I did not like the implode() ... explode() workaround that you had to use. As of d0103c0, this is no longer necessary. Once you adapted your PR to that, I think we can merge this. Thanks!

[joke2k]

Adapted the code with your main to use the new cliArguments methods.
I tested locally but I recently updated my php to 8.1.22 and I receive some wired error on some phpt tests like:

/open-source/phpunit/tests/end-to-end/regression/765.phpt
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
 
 ERRORS!
 Tests: 1, Assertions: 1, Errors: 1.
+Standard input code:8:
 int(2)

but I can see that your pipeline is working on the main, so I think is an issue only on my laptop.

[sebastianbergmann]

This branch cannot be rebased due to conflicts.

[joke2k]

Hi @sebastianbergmann, I squashed all the commits and rebased the branch.