Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate IgnoreClassForCodeCoverage, IgnoreMethodForCodeCoverage, and IgnoreFunctionForCodeCoverage attributes #5513

Closed
2 tasks
sebastianbergmann opened this issue Sep 16, 2023 · 0 comments
Closed
2 tasks

Deprecate IgnoreClassForCodeCoverage, IgnoreMethodForCodeCoverage, and IgnoreFunctionForCodeCoverage attributes #5513

sebastianbergmann opened this issue Sep 16, 2023 · 0 comments
Assignees
@sebastianbergmann
Labels
feature/code-coverage Issues related to code coverage (but not php-code-coverage) feature/metadata/attributes type/deprecation Something will be/is deprecated
Milestone
PHPUnit 10.4

Comments

@sebastianbergmann
Copy link
Owner

sebastianbergmann commented Sep 16, 2023 •
edited

Implementing the IgnoreClassForCodeCoverage, IgnoreMethodForCodeCoverage, and IgnoreFunctionForCodeCoverage attributes was a bad idea.

php-code-coverage will continute to support docblock-level @codeCoverageIgnore annotations on units of code such as classes or methods as well as the inline annotations @codeCoverageIgnoreStart, @codeCoverageIgnoreEnd, and @codeCoverageIgnore. Due to the reasons explained in #5235, we have to stick to annotations in comments here instead of using attributes.

Timeline

These changes need to be rolled back:

This will not be implemented:
@sebastianbergmann sebastianbergmann added feature/code-coverage Issues related to code coverage (but not php-code-coverage) type/deprecation Something will be/is deprecated feature/metadata/attributes labels Sep 16, 2023
@sebastianbergmann sebastianbergmann added this to the PHPUnit 10.4 milestone Sep 16, 2023
@sebastianbergmann sebastianbergmann self-assigned this Sep 16, 2023
@sebastianbergmann sebastianbergmann mentioned this issue Sep 16, 2023
Closed
@sebastianbergmann sebastianbergmann changed the title Deprecate Implement IgnoreClassForCodeCoverage, IgnoreMethodForCodeCoverage, and IgnoreFunctionForCodeCoverage attributes Deprecate IgnoreClassForCodeCoverage, IgnoreMethodForCodeCoverage, and IgnoreFunctionForCodeCoverage attributes Sep 16, 2023
@sebastianbergmann sebastianbergmann mentioned this issue Sep 16, 2023
Closed
@sebastianbergmann sebastianbergmann mentioned this issue Sep 16, 2023
Closed
3 tasks
sebastianbergmann added a commit to sebastianbergmann/phpunit-documentation-english that referenced this issue Sep 16, 2023
@sebastianbergmann
Sync with sebastianbergmann/phpunit#5513
58b6026
@sebastianbergmann sebastianbergmann mentioned this issue Sep 16, 2023
Closed
sebastianbergmann added a commit that referenced this issue Sep 16, 2023
@sebastianbergmann
Closes #5513
20032ed
vudaltsov added a commit to vudaltsov/rector-phpunit that referenced this issue Oct 28, 2023
@vudaltsov
Removed @codeCoverageIgnore to attribute conversion
60b9f1e 
See sebastianbergmann/phpunit#5513.
@vudaltsov vudaltsov mentioned this issue Oct 28, 2023
Closed
This was referenced Jan 3, 2024
Closed
Merged
@steevanb steevanb mentioned this issue Apr 24, 2024
Closed
@cyl3x cyl3x mentioned this issue Jul 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastianbergmann sebastianbergmann

Labels
feature/code-coverage Issues related to code coverage (but not php-code-coverage) feature/metadata/attributes type/deprecation Something will be/is deprecated
Projects
None yet
Milestone
PHPUnit 10.4
Development

No branches or pull requests
1 participant
@sebastianbergmann