Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bundled code bug where the modules identifier is undeclared #151

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

jeparlefrancais
Copy link
Contributor

@jeparlefrancais jeparlefrancais commented Nov 6, 2023

The generated code when bundling is broken and the modules identifier is not declared when running through the load function.

  • add entry to the changelog

Copy link

github-actions bot commented Nov 6, 2023

Coverage after merging fix-bundle-module-local-bug into main will be

86.98%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
src/rules/bundle/path_require_mode
   module_definitions.rs80.48%100%76%81.03%105–109, 114, 133, 17, 277–278, 296–297, 317, 321, 333, 337–341, 343, 346–348, 350, 353–370, 373–375, 377, 420–422, 47–50, 53–56, 72, 78–79

@jeparlefrancais jeparlefrancais merged commit 961f52a into main Nov 6, 2023
6 checks passed
@jeparlefrancais jeparlefrancais deleted the fix-bundle-module-local-bug branch November 6, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant