Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor bundling to use cached function calls to load modules #147

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

jeparlefrancais
Copy link
Contributor

@jeparlefrancais jeparlefrancais commented Nov 3, 2023

Closes #143

To fix the issue, the bundler will generate functions to load each modules, instead of generating simple do blocks.

  • add entry to the changelog

Copy link

github-actions bot commented Nov 3, 2023

Coverage after merging fix-bundle-module-loading into main will be

87.07%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
src/nodes/expressions
   table.rs89.28%100%85.71%90.20%115–119, 192–195, 218–222, 253–254, 365–367, 46–48
src/nodes/statements
   if_statement.rs76.03%100%74.58%76.39%116–119, 158–165, 226–231, 233–235, 237–238, 251–253, 261–264, 27–30, 317–323, 49–55
src/nodes/types
   type_field.rs61.97%100%66.67%60.71%33–35, 52–57, 59–64, 73–78
src/rules/bundle/path_require_mode
   mod.rs84.89%100%89.47%84.56%100–102, 119–121, 125–127, 129, 179, 205–207, 222–224, 234–236, 258, 294–297, 325–326, 332–338, 348–349, 35, 358–360
   module_definitions.rs80.31%100%76%80.85%105–109, 114, 133, 17, 273–274, 292–293, 313, 317, 329, 333–337, 339, 342–344, 346, 349–366, 369–371, 373, 416–418, 47–50, 53–56, 72, 78–79

@jeparlefrancais jeparlefrancais merged commit 9ae3158 into main Nov 3, 2023
6 checks passed
@jeparlefrancais jeparlefrancais deleted the fix-bundle-module-loading branch November 3, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix bundling modules with early returns
1 participant