-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use new k8s registry #44
Conversation
Signed-off-by: yuvraj singh shekhawat <shekhawatyuvraj1998@gmail.com>
@Stevent-fei ,could you help to confirm whether this modification is compatible? |
@Stevent-fei @kakaZhou719 can you merge this? |
ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@yuvraj9 This modification will lead to incompatibility. After the modification, there will be some problems. It will not be merged into the main branch first. let me check the cause of the problem first |
@Stevent-fei just a reminder for this. Also let me know if i can help in someway. |
@Stevent-fei any update on this? |
@ahmedwaleedmalik @yuvraj9 I am ready to merge this code into the main branch, and the issue has been resolved. |
This PR migrate from k8s.gcr.io to registry.k8s.io
Fixes #43
Fixes kubernetes/k8s.io#4780