Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate MultiTableMetadata in favor for Metadata #2172

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Deprecate MultiTableMetadata in favor for Metadata #2172

merged 2 commits into from
Aug 6, 2024

Conversation

lajohn4747
Copy link
Contributor

resolves #2129
CU-86b19awxk

@lajohn4747 lajohn4747 requested a review from a team as a code owner August 5, 2024 23:46
@sdv-team
Copy link
Contributor

sdv-team commented Aug 5, 2024

Task linked: CU-86b19awxk SDV - Enable multi table synthesizers to use new Metadata #2129

amontanez24
amontanez24 reviewed Aug 6, 2024
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo but besides that LGTM!

tests/integration/metadata/test_metadata.py Outdated Show resolved Hide resolved
@lajohn4747 lajohn4747 merged commit ade6327 into feature/metadata Aug 6, 2024
39 checks passed
@lajohn4747 lajohn4747 deleted the issue_2129_deprecate_multi_fix branch August 6, 2024 17:51
@lajohn4747 lajohn4747 mentioned this pull request Aug 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amontanez24 amontanez24 amontanez24 approved these changes

@pvk-developer pvk-developer pvk-developer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lajohn4747 @sdv-team @amontanez24 @pvk-developer