Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate MultiTableMetadata in favor for Metadata #2171

Closed
wants to merge 9 commits into from

Conversation

lajohn4747
Copy link
Contributor

resolves #2129
CU-86b19awxk

@lajohn4747 lajohn4747 requested a review from a team as a code owner August 5, 2024 20:37
@sdv-team
Copy link
Contributor

sdv-team commented Aug 5, 2024

Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to either rebase this off the target branch or rebase the target branch off of main

@@ -914,6 +914,47 @@ def get_table_metadata(self, table_name):
self._validate_table_exists(table_name)
return deepcopy(self.tables[table_name])

def anonymize(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it treating this as new code?

@lajohn4747
Copy link
Contributor Author

Will try to rebase entirely to avoid extra commits

@lajohn4747 lajohn4747 closed this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants