Primary keys may not be unique for variable length regexes #2161

amontanez24 · 2024-08-01T23:34:35Z

resolves #2116
CU-86b17dk49

sdv-team · 2024-08-02T19:23:28Z

tests/unit/single_table/test_base.py

sdv/multi_table/base.py

tests/unit/single_table/test_base.py

amontanez24 added 6 commits July 31, 2024 18:14

Adding initial functionality

c80f842

Getting tests to pass

cb349d4

getting integration tests to pass

f4fa711

surfacing other errors fixing import

943fcf4

Adding unit tests

f47dbf0

Improving test descriptions

7ddcf42

amontanez24 marked this pull request as ready for review August 2, 2024 19:22

amontanez24 requested a review from a team as a code owner August 2, 2024 19:22

amontanez24 requested review from rwedge and pvk-developer and removed request for a team August 2, 2024 19:22

pvk-developer reviewed Aug 5, 2024

View reviewed changes

tests/unit/single_table/test_base.py Outdated Show resolved Hide resolved

sdv/multi_table/base.py Show resolved Hide resolved

rwedge approved these changes Aug 5, 2024

View reviewed changes

tests/unit/single_table/test_base.py Outdated Show resolved Hide resolved

tests/unit/single_table/test_base.py Outdated Show resolved Hide resolved

feedback

ac486a6

amontanez24 requested a review from pvk-developer August 5, 2024 21:38

pvk-developer approved these changes Aug 6, 2024

View reviewed changes

amontanez24 merged commit 87318d0 into main Aug 6, 2024
39 checks passed

amontanez24 deleted the issue-2116-pk-unique-regex branch August 6, 2024 14:13

Provide feedback