Mock every usage of is_faker_function to speed up the unit tests

[R-Palazzo]

CU-86b18qaaz
Resolve #2163

[sdv-team]

Task linked: CU-86b18qaaz SDV - Metadata.add_column can be slow #2125

[amontanez24]

Nice job, this is much faster! While we're at it can you fix this unit test to not actually fit and sample from the model. If we can just mock the _model part or something. This is the only test that still takes over a second

[R-Palazzo]

Nice job, this is much faster! While we're at it can you fix this unit test to not actually fit and sample from the model. If we can just mock the _model part or something. This is the only test that still takes over a second

Hi @amontanez24, I didn’t find a good way to mock some methods while preserving the test logic, so I moved it to the integration folder. It also makes sense to have it in the integration tests because it validates end-to-end whether the estimated number of columns matches the actual one when we fit and sample HMA. There are still other tests in the unit folder for the _estimate_num_columns method. Let me know if it works. The change is in 75387aa

[fealho]

@amontanez24 Are we allowed to use mocks in integration tests?

[amontanez24]

Yeah that's a good question. Ideally you wouldn't have to. This test is a little strange in that it is mocking the internals of another method (_finalize), to assert that the method under test is returning the right values. I'm not really sure of the context, so I don't know why this is the case.

Ideally, this test would just run _estimate_num_columns, and we'd know what the result should be and could just assert that outcome.