Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing conditions in ScalarRange for is_datetime #2150

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Deathn0t
Copy link
Contributor

I suggest updating the condition that checks for datetime types in ScalarRange.

This resulted in an exception when the range values could be interpreted as dates (e.g., 1900, 2000) even though the column type is int.

Therefore I suggest raisin the exception only when the column is a datetime and not both low/high values of the range are datetime.

@Deathn0t Deathn0t requested a review from a team as a code owner July 26, 2024 08:16
@Deathn0t Deathn0t requested review from rwedge and removed request for a team July 26, 2024 08:16
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.62%. Comparing base (80c01c1) to head (c95fb5a).
Report is 151 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2150      +/-   ##
==========================================
+ Coverage   97.35%   97.62%   +0.27%     
==========================================
  Files          51       57       +6     
  Lines        4869     5773     +904     
==========================================
+ Hits         4740     5636     +896     
- Misses        129      137       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Deathn0t
Copy link
Contributor Author

Hello, would you have any update or comment on this PR? the changes are relatively small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants