Use metadata over singletablemetadata #2144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
lajohn4747
requested review from
npatki,
amontanez24,
frances-h and
pvk-developer
lajohn4747
changed the title
pvk-developer
requested changes
Jul 24, 2024
| @@ -254,7 +254,7 @@ def _validate_metadata_specific_to_constraint(metadata, **kwargs): | |||
| invalid_columns = [] | |||
| column_names = kwargs.get('column_names') | |||
| for column in column_names: | |||
| if metadata.columns[column]['sdtype'] not in ['boolean', 'categorical']: | |||
| if metadata.get_columns()[column]['sdtype'] not in ['boolean', 'categorical']: | |||
There was a problem hiding this comment.
This won't be backwards compatible. SingleTableMetadata does not have get_columns().
There was a problem hiding this comment.
Made it backwards compatible by making sure all metadata is converted and also convert it the synthesizer metadata on load.
Also added an integration test for backward compatibility.
lajohn4747
changed the title
frances-h
reviewed
Jul 26, 2024
Co-authored-by: gsheni <gvsheni@gmail.com>
|
Closing as we landed #2140 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2128
CU-86b19amxa
Made metadata work with single table synthesizers by converting
SingleTableMetadatatoMetadatabefore inserting into the synthesizers. Write a wrapper method so that all single table synthesizers can use Metadata when there is only one table.Wrote unit tests and update tests to use the methods instead of directly accessing
SingleTableMetadataattributes.