Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support null foreign keys in HMA Synthesizer #2124

Merged
merged 17 commits into from
Aug 15, 2024
Merged

Support null foreign keys in HMA Synthesizer #2124

merged 17 commits into from
Aug 15, 2024

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented Jul 12, 2024

Fixes #2063

CU-86b0wdby9

@sdv-team
Copy link
Contributor

Task linked: CU-86b0wdby9 SDV - Support nullable foreign keys in HMA #2063

@frances-h frances-h marked this pull request as ready for review July 18, 2024 01:07
@frances-h frances-h requested a review from a team as a code owner July 18, 2024 01:07
@frances-h frances-h requested review from amontanez24 and gsheni and removed request for a team July 18, 2024 01:07
amontanez24
amontanez24 reviewed Jul 18, 2024
View reviewed changes
sdv/multi_table/hma.py Show resolved Hide resolved
sdv/multi_table/hma.py Show resolved Hide resolved
gsheni
gsheni approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@gsheni gsheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 suggestions for setting dtypes.

tests/integration/multi_table/test_hma.py Outdated Show resolved Hide resolved
tests/integration/multi_table/test_hma.py Outdated Show resolved Hide resolved
rwedge and others added 2 commits August 14, 2024 14:31
@rwedge @gsheni
Set dtypes for some test case Series
897b3eb 
Co-authored-by: Gaurav Sheni <gvsheni@gmail.com>
@rwedge
single quotes preferred
3ef2b1d
@rwedge rwedge merged commit b1ae0b2 into nullable_foreign_keys Aug 15, 2024
39 checks passed
@rwedge rwedge deleted the null_hma_backup branch August 15, 2024 14:08
rwedge added a commit that referenced this pull request Aug 16, 2024
@rwedge @frances-h @gsheni
Support null foreign keys in HMA Synthesizer (#2124)
835d412 
Co-authored-by: Frances Hartwell <frances@datacebo.com>
Co-authored-by: Gaurav Sheni <gvsheni@gmail.com>
rwedge added a commit that referenced this pull request Aug 20, 2024
@rwedge @frances-h @gsheni
Support null foreign keys in HMA Synthesizer (#2124)
89e1c23 
Co-authored-by: Frances Hartwell <frances@datacebo.com>
Co-authored-by: Gaurav Sheni <gvsheni@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amontanez24 amontanez24 amontanez24 approved these changes

@gsheni gsheni gsheni approved these changes

@frances-h frances-h Awaiting requested review from frances-h

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rwedge @sdv-team @amontanez24 @gsheni @frances-h