Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added constant for float relative tolerance #2071

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rgerkin
Copy link

@rgerkin rgerkin commented Jun 14, 2024

There is currently no user-accessible way to control the float tolerance for conditionally sampling. While exposing this in the API would be best, this PR at least allows the user to modify this value directly in the module.

N.B. There are actually 2 different values of float_rtol used in the module, one was 0.1 by default and the rest were 0.01. I set these all to the same constant, since I saw no clear reason why they should be different.

@rgerkin rgerkin requested a review from a team as a code owner June 14, 2024 23:28
@rgerkin rgerkin requested review from amontanez24 and removed request for a team June 14, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant