Update AdoptOpenJDK 8 & 11, add upstream OpenJDK 8 & 11 (Linux & Windows) #171
Conversation
| @ChangeSet(order = "209", id = "209-add_openjdk_8_0_232", author = "andrebrait") | ||
| def migrate209(implicit db: MongoDatabase) = { | ||
| List( | ||
| Version("java", "8.0.232-open", "https://github.com/AdoptOpenJDK/openjdk8-upstream-binaries/releases/download/jdk8u232-b09/OpenJDK8U-jdk_x64_linux_8u232b09.tar.gz", Linux64), |
There was a problem hiding this comment.
We can't really add adoptopenjdk builds as -open because this is reserved for reference implementation JDKs coming from http://jdk.java.net.
They aren't releasing any new versions of JDK8, and only seem to have new RIs for 11, 12 and 13 now.
There was a problem hiding this comment.
@marc0der Although the URLs are from AdoptOpenJDK, these are actually binaries from upstream builds of the OpenJDK (see https://adoptopenjdk.net/upstream.html and AdoptOpenJDK/TSC#65)
So these are provided by AdoptOpenJDK on behalf of RedHat as builds of the reference implementation. We can find another name for them, if you want (perhaps redhat?) but these are technically the continuation of what is provided in http://jdk.java.net
There was a problem hiding this comment.
@andrebrait Thanks for the explanation, it makes perfect sense now. I think keeping it under the -open label works perfectly in that case.
Going forward, would it be an idea for the AdoptOpenJDK project to start using our vendor API instead of using PRs? This could make things a lot easier than using a PR for each new release.
Note: Unfortunately, AdoptOpenJDK doesn't build upstream binaries for macOS