[BREAKING] Remove parametric modeling code #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdwardPayne
added a commit
to EdwardPayne/NeuralAmpModelerReamping
that referenced
this pull request
Dec 30, 2023
* Move pre-warm to DSP and call it in get_dsp() (sdatkinson#90) * Add nam namespace (sdatkinson#93) * Fix tools (sdatkinson#94) * [BREAKING] Remove parametric modeling code (sdatkinson#95) * Get rid of parametric modeling code * Virtual set condition array * Bump version to 0.1.0 --------- Co-authored-by: Mike Oliphant <oliphant@nostatic.org> Co-authored-by: Steven Atkinson <steven@atkinson.mn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #81.
Also renaming "params" variables to "weights" where it's referring to model weights (aka parameters, but since I've used "parametric" in NAM to refer to modeling that's parameterized wrt "real world" parameters, I want it to not be confusing).
Note: I've attempted to leave in hooks in locations where extending this library's classes to recover the parametric functionality can be done by downstream projects who are interested in it without having to tear up too much code. Hence the virtual methods in the WaveNet, e.g.