Remove _process_core() and output normalization #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of caching in local variables. Removed output normalization. Added functions for getting model normalization factor in dB and linear gain.
sdatkinson
approved these changes
Oct 15, 2023
| @@ -63,44 +63,26 @@ class DSP | |||
| // DSP subclass implementation. | |||
| virtual void finalize_(const int num_frames); | |||
| double GetExpectedSampleRate() const { return mExpectedSampleRate; }; | |||
| bool HasLoudness() { return mLoudness != TARGET_DSP_LOUDNESS; }; | |||
| void SetNormalize(const bool normalize) { this->mNormalizeOutputLoudness = normalize; }; | |||
| bool HasNormalization() { return mLoudness != TARGET_DSP_LOUDNESS; }; | |||
There was a problem hiding this comment.
Nit: this'll work, but I'm going to mess w/ this a little bit. (I prefer "loudness" since I'm going to remove the "target" from this and let downstream users of this library decide for themselves how loud they want to aim for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed _process_core(). Pass input/output/num_frames where needed instead of caching in local variables. Removed output normalization. Added functions for getting model normalization factor in dB and linear gain.
I also removed the anti-pop code for ConvNet - it needs to be replaced with a pre-warm.
Resolves #79