Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiler warnings #53

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Fix compiler warnings #53

merged 1 commit into from
Jun 20, 2023

Conversation

falkTX
Copy link
Contributor

@falkTX falkTX commented Jun 15, 2023

This PR fixes several compiler warnings generated by GCC under Linux.
They are quite a few but related to just 2 issues:

  1. Comparison of signed vs unsigned types (because std::vector<>::size() returns size_t which is unsigned)
  2. C++ class constructors have wrong member initialization order

@falkTX
Fix compiler warnings
3ccec46 
Signed-off-by: falkTX <falktx@falktx.com>
sdatkinson
sdatkinson approved these changes Jun 20, 2023
View reviewed changes
Copy link
Owner

@sdatkinson sdatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@sdatkinson sdatkinson merged commit 104685b into sdatkinson:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdatkinson sdatkinson sdatkinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@falkTX @sdatkinson