dns: cleanups #2481
Merged
dns: cleanups #2481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as suggested by its comment: ```c /* Legacy typedef, don't use, you can't specify "const" */ typedef struct ares_channeldata *ares_channel; /* Current main channel typedef */ typedef struct ares_channeldata ares_channel_t; ``` this change has no impact so far, as we don't pass the `&_channel` around. the constness is more important to the c-ares library. but let's use the suggested typedef, the name is more consistent with other typedefs provided by c-ares library. Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>
the parameter passed to `ares_library_init()` is a bitmap. so 0 is indeed nothing but `ARES_LIB_INIT_NONE` is more readable. Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this changeset includes two trivial cleanups. they were inspired when auditing the c-ares code.