Skip to content

Commit

Permalink
build: support c-ares >= 1.34.1
Browse files Browse the repository at this point in the history
in c-ares 1.34.0, it addressed a regression with custom socket callbacks
due to DNS cookie support. because 1.34.0's release tarball failed to
include some header file. so let's claim the support to
c-ares < 1.33 or >= 1.34.1.

Refs #2472
Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>
  • Loading branch information
tchaikov authored and avikivity committed Oct 16, 2024
1 parent f14d2d7 commit c1a2085
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions cmake/SeastarDependencies.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -167,10 +167,10 @@ macro (seastar_find_dependencies)
find_package(Protobuf 2.5.0 REQUIRED)
endif ()

if (c-ares_VERSION VERSION_GREATER_EQUAL 1.33)
if (c-ares_VERSION VERSION_GREATER_EQUAL 1.33.0 AND c-ares_VERSION VERSION_LESS 1.34.1)
# https://github.com/scylladb/seastar/issues/2472
message (FATAL_ERROR
"c-ares ${c-ares_VERSION} is not supported. "
"Seastar requires c-ares version lower than 1.33")
"Seastar requires c-ares version <1.33 or >=1.34.1 ")
endif ()
endmacro ()

0 comments on commit c1a2085

Please sign in to comment.