forked from privacy-scaling-explorations/zkevm-circuits
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support EIP-3860 (Limit and meter initcode) for Shanghai #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
github-merge-queue bot
pushed a commit
to privacy-scaling-explorations/zkevm-circuits
that referenced
this pull request
Jun 2, 2023
…es (#1424) ### Description 1. Add Shanghai related fields to chain config in geth-utils. 2. EIP-3651 (Warm COINBASE): add a new access-list write for coinbase to Begin TX. 3. Part of EIP-3860 (Limit and meter initcode): only add gas cost of init code to Begin TX (missing gas cost changes in Create and OOG Create). ### Issue Link Issue #1362 Local related PRs: scroll-tech#497 scroll-tech#500 scroll-tech#507 Reference previous PR: #1361 ### Type of change - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) ### How Has This Been Tested? Unit test cases of CI could pass with Shanghai geth traces. --------- Co-authored-by: Zhang Zhuo <mycinbrin@gmail.com>
This was referenced Jul 7, 2023
johntaiko
pushed a commit
to johntaiko/zkevm-circuits
that referenced
this pull request
Aug 20, 2023
…es (privacy-scaling-explorations#1424) 1. Add Shanghai related fields to chain config in geth-utils. 2. EIP-3651 (Warm COINBASE): add a new access-list write for coinbase to Begin TX. 3. Part of EIP-3860 (Limit and meter initcode): only add gas cost of init code to Begin TX (missing gas cost changes in Create and OOG Create). Issue privacy-scaling-explorations#1362 Local related PRs: scroll-tech#497 scroll-tech#500 scroll-tech#507 Reference previous PR: privacy-scaling-explorations#1361 - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) Unit test cases of CI could pass with Shanghai geth traces. --------- Co-authored-by: Zhang Zhuo <mycinbrin@gmail.com>
johntaiko
pushed a commit
to johntaiko/zkevm-circuits
that referenced
this pull request
Aug 20, 2023
…es (privacy-scaling-explorations#1424) 1. Add Shanghai related fields to chain config in geth-utils. 2. EIP-3651 (Warm COINBASE): add a new access-list write for coinbase to Begin TX. 3. Part of EIP-3860 (Limit and meter initcode): only add gas cost of init code to Begin TX (missing gas cost changes in Create and OOG Create). Issue privacy-scaling-explorations#1362 Local related PRs: scroll-tech#497 scroll-tech#500 scroll-tech#507 Reference previous PR: privacy-scaling-explorations#1361 - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) Unit test cases of CI could pass with Shanghai geth traces. --------- Co-authored-by: Zhang Zhuo <mycinbrin@gmail.com>
johntaiko
pushed a commit
to johntaiko/zkevm-circuits
that referenced
this pull request
Aug 20, 2023
…es (privacy-scaling-explorations#1424) 1. Add Shanghai related fields to chain config in geth-utils. 2. EIP-3651 (Warm COINBASE): add a new access-list write for coinbase to Begin TX. 3. Part of EIP-3860 (Limit and meter initcode): only add gas cost of init code to Begin TX (missing gas cost changes in Create and OOG Create). Issue privacy-scaling-explorations#1362 Local related PRs: scroll-tech#497 scroll-tech#500 scroll-tech#507 Reference previous PR: privacy-scaling-explorations#1361 - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) Unit test cases of CI could pass with Shanghai geth traces. --------- Co-authored-by: Zhang Zhuo <mycinbrin@gmail.com>
johntaiko
pushed a commit
to johntaiko/zkevm-circuits
that referenced
this pull request
Aug 20, 2023
…es (privacy-scaling-explorations#1424) 1. Add Shanghai related fields to chain config in geth-utils. 2. EIP-3651 (Warm COINBASE): add a new access-list write for coinbase to Begin TX. 3. Part of EIP-3860 (Limit and meter initcode): only add gas cost of init code to Begin TX (missing gas cost changes in Create and OOG Create). Issue privacy-scaling-explorations#1362 Local related PRs: scroll-tech#497 scroll-tech#500 scroll-tech#507 Reference previous PR: privacy-scaling-explorations#1361 - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) Unit test cases of CI could pass with Shanghai geth traces. --------- Co-authored-by: Zhang Zhuo <mycinbrin@gmail.com>
chokobole
added a commit
to kroma-network/zkevm-circuits
that referenced
this pull request
Apr 18, 2024
chokobole
added a commit
to kroma-network/zkevm-circuits
that referenced
this pull request
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Geth related code
ExecutionResult
) from TransitionDb.Seems no need to fix
BeginTx
.CREATE
andCREATE2
when this EIP is enabled.Need to fix
Create
andOOG Create
.Fix summary
shanghai
feature and not-shanghai toeth-types
.Move
OOG Create
fromDynamicMemoryExpansion
toOOG Create2
. Since both CREATE and CREATE2 need to check with maximum init code size.In
CreateGadget
andErrorOOGCreateGadget
, check withMAX_INIT_CODE_SIZE
, and useCREATE_GAS_PER_CODE_WORD
andCREATE2_GAS_PER_CODE_WORD
to calculate gas cost.Issue Link
#504
Upstream issue privacy-scaling-explorations#1368
Type of change
Test
Add a new test case
test_oog_create_max_init_code_size
to OOG Create.And Test cases of
CreateGadget
andErrorOOGCreateGadget
could pass forshanghai
feature and not-shanghai.