forked from privacy-scaling-explorations/zkevm-circuits
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support shanghai in geth tracer #497
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i changed the order of sub tasks here @silathdiir |
i think after the first 2 sub tasks, ci can pass for shanghai feature. So we can merge it then start new sub tasks in new prs |
1 task
github-merge-queue bot
pushed a commit
to privacy-scaling-explorations/zkevm-circuits
that referenced
this pull request
Jun 2, 2023
…es (#1424) ### Description 1. Add Shanghai related fields to chain config in geth-utils. 2. EIP-3651 (Warm COINBASE): add a new access-list write for coinbase to Begin TX. 3. Part of EIP-3860 (Limit and meter initcode): only add gas cost of init code to Begin TX (missing gas cost changes in Create and OOG Create). ### Issue Link Issue #1362 Local related PRs: scroll-tech#497 scroll-tech#500 scroll-tech#507 Reference previous PR: #1361 ### Type of change - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) ### How Has This Been Tested? Unit test cases of CI could pass with Shanghai geth traces. --------- Co-authored-by: Zhang Zhuo <mycinbrin@gmail.com>
johntaiko
pushed a commit
to johntaiko/zkevm-circuits
that referenced
this pull request
Aug 20, 2023
…es (privacy-scaling-explorations#1424) 1. Add Shanghai related fields to chain config in geth-utils. 2. EIP-3651 (Warm COINBASE): add a new access-list write for coinbase to Begin TX. 3. Part of EIP-3860 (Limit and meter initcode): only add gas cost of init code to Begin TX (missing gas cost changes in Create and OOG Create). Issue privacy-scaling-explorations#1362 Local related PRs: scroll-tech#497 scroll-tech#500 scroll-tech#507 Reference previous PR: privacy-scaling-explorations#1361 - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) Unit test cases of CI could pass with Shanghai geth traces. --------- Co-authored-by: Zhang Zhuo <mycinbrin@gmail.com>
johntaiko
pushed a commit
to johntaiko/zkevm-circuits
that referenced
this pull request
Aug 20, 2023
…es (privacy-scaling-explorations#1424) 1. Add Shanghai related fields to chain config in geth-utils. 2. EIP-3651 (Warm COINBASE): add a new access-list write for coinbase to Begin TX. 3. Part of EIP-3860 (Limit and meter initcode): only add gas cost of init code to Begin TX (missing gas cost changes in Create and OOG Create). Issue privacy-scaling-explorations#1362 Local related PRs: scroll-tech#497 scroll-tech#500 scroll-tech#507 Reference previous PR: privacy-scaling-explorations#1361 - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) Unit test cases of CI could pass with Shanghai geth traces. --------- Co-authored-by: Zhang Zhuo <mycinbrin@gmail.com>
johntaiko
pushed a commit
to johntaiko/zkevm-circuits
that referenced
this pull request
Aug 20, 2023
…es (privacy-scaling-explorations#1424) 1. Add Shanghai related fields to chain config in geth-utils. 2. EIP-3651 (Warm COINBASE): add a new access-list write for coinbase to Begin TX. 3. Part of EIP-3860 (Limit and meter initcode): only add gas cost of init code to Begin TX (missing gas cost changes in Create and OOG Create). Issue privacy-scaling-explorations#1362 Local related PRs: scroll-tech#497 scroll-tech#500 scroll-tech#507 Reference previous PR: privacy-scaling-explorations#1361 - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) Unit test cases of CI could pass with Shanghai geth traces. --------- Co-authored-by: Zhang Zhuo <mycinbrin@gmail.com>
johntaiko
pushed a commit
to johntaiko/zkevm-circuits
that referenced
this pull request
Aug 20, 2023
…es (privacy-scaling-explorations#1424) 1. Add Shanghai related fields to chain config in geth-utils. 2. EIP-3651 (Warm COINBASE): add a new access-list write for coinbase to Begin TX. 3. Part of EIP-3860 (Limit and meter initcode): only add gas cost of init code to Begin TX (missing gas cost changes in Create and OOG Create). Issue privacy-scaling-explorations#1362 Local related PRs: scroll-tech#497 scroll-tech#500 scroll-tech#507 Reference previous PR: privacy-scaling-explorations#1361 - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) Unit test cases of CI could pass with Shanghai geth traces. --------- Co-authored-by: Zhang Zhuo <mycinbrin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
shanghai
feature to bus-mapping, zkevm-circuits, mock and testool.Add shanghai config fields to a new struct
ChainConfig
in external-tracer. It is optional inTraceConfig
.Fix to merge
ChainConfig
(if not null) from external-tracer in geth-utils.Test
Test feature
shanghai
for part test cases as:TODO
Suppose to work on other tasks in separate PRs. Move to issue #504.
add a feature flag "shanghai", with which, the shanghai fork of geth tracer used, the some circuit constraints changed accordingly like the gas of init code / warm coin base.
we can either merge this after ci pass (without push0), or add push0 to this pr too.
shanghai
feature #500shanghai
feature toSELFDESTRUCT
as DisableSELFDESTRUCT
for featurescroll
#463