Skip to content

Commit

Permalink
fix: Fix serialization for VerifyingKey (privacy-scaling-explorations…
Browse files Browse the repository at this point in the history
…#178)

Now the value returned when the number of selectors is a multiple of 8
is correct.

Resolves: privacy-scaling-explorations#175
  • Loading branch information
CPerezz authored and Velaciela committed Oct 9, 2023
1 parent dd22b61 commit e56d03f
Showing 1 changed file with 7 additions and 8 deletions.
15 changes: 7 additions & 8 deletions halo2_proofs/src/plonk.rs
Original file line number Diff line number Diff line change
Expand Up @@ -168,14 +168,13 @@ where
fn bytes_length(&self) -> usize {
8 + (self.fixed_commitments.len() * C::default().to_bytes().as_ref().len())
+ self.permutation.bytes_length()
/*
+ self.selectors.len()
* (self
.selectors
.get(0)
.map(|selector| selector.len() / 8 + 1)
.unwrap_or(0))
*/
// scroll/halo2: we don’t need to store
// + self.selectors.len()
// * (self
// .selectors
// .get(0)
// .map(|selector| (selector.len() + 7) / 8)
// .unwrap_or(0))
}

fn from_parts(
Expand Down

0 comments on commit e56d03f

Please sign in to comment.