Adding endpoint config to enable minio backend #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch! quick question with regards to the disable ssl setting, this is only specific to your minio setup right? if so, I can help push a change to make it configurable. |
added 3 commits
March 24, 2020 17:04
This is that we can run objinsync in a sidecar container under a different uid than the one used in the main application container
Would be nice if made configurable. In my case it is over http(insecured). I did follow https://docs.minio.io/docs/how-to-use-aws-sdk-for-go-with-minio-server |
|
thanks for the context, sent a PR to your fork: neodino#1. Can you try it out and see if it works for your setup? |
feat: make endpoint and disable ssl configurable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in relation to #5