Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solves issue #171 #195

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solves issue #171 #195

wants to merge 1 commit into from

Conversation

AbhinavSE
Copy link

@AbhinavSE AbhinavSE commented May 13, 2022

As @wjdp suggested in the issue #171 , an apostrophe in the channel's name causes the JSONdecode error. the json.loads() function fails when there are hex codes like "\x27" in the script. So I created a function in the jsonld extractor to replace the hex codes with their special characters before passing it into json.loads() function.

Copy link

@wjdp wjdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AbhinavSE, looks like this should work.

Unsure if there's a python lib that can handle the cleaning, do you expect characters outside the set provided? I'm thinking about special chars in other languages.

@AbhinavSE
Copy link
Author

Thanks @AbhinavSE, looks like this should work.

Unsure if there's a python lib that can handle the cleaning, do you expect characters outside the set provided? I'm thinking about special chars in other languages.

There's less chances for there to be new characters, but these are YouTube channel names, so there's a chance. But for now, this should work without affecting the runtime by too much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants