-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v2.1.0 #73
Merged
Release v2.1.0 #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add conditionals to pre-commit steps so they only run for one Python environment (3.8) * Remove explicit linting task, as it's captured by the flake8 pre-commit hook
Fix testing copy-pasta typo
MarkKoz
suggested changes
Mar 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't want to cache the pre-commit cache in CI?
I guess that would probably be helpful, oops 😄 |
Update pre-commit conditional to include an escape if a previous step has failed Co-Authored-By: Mark <kozlovmark@gmail.com>
MarkKoz
suggested changes
Mar 6, 2020
Co-Authored-By: Mark <kozlovmark@gmail.com>
MarkKoz
approved these changes
Mar 6, 2020
Set minimum supported Python version to 3.6.1 to mitigate NamedTuple's lack of support for methods and defaults in Python 3.6.0
Fixed typo in README.md
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
[v2.1.0]
Added
--suppress-dummy-args
configuration option to suppress ANN000 level errors for dummy arguments, defined as"_"
Additional Details
This release adds the opinionated
--suppress-dummy-args
flag, as requested by #68. If this flag is set,TYP000
-level errors are suppressed for "dummy" arguments, defined as_
.For example:
Would not yield an
ANN001
error for the dummy argument:The default value of this configuration option is
False
, so this addition should be transparent to existing users.Also added in this PR are the pre-commit hooks to CI, as also done with the other repos in the organization. As part of this change, the explicit Flake8 step is removed, as the pre-commit hooks already run Flake8. The pre-commit hooks are also tied to a conditional to only run it in a single build environment, Python 3.8, rather than across all of them.
Closes #68