Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove upper bound for python dependency #155

Merged
merged 2 commits into from
May 3, 2023
Merged

Remove upper bound for python dependency #155

merged 2 commits into from
May 3, 2023

Conversation

nat-n
Copy link
Contributor

@nat-n nat-n commented May 2, 2023

Currently this project declares that it is not compatible with python >=4.0, this sounds reasonable in that
"python 4.0" is kind of an abstract concept, but has the unfortunate side effect that any projects that do not make the same declaration cannot depend on flake8-broken-line, or any other project that depends on it!

This post elaborates better than I can on why it is a better practice to only set a lower bound for python compatibility in almost all cases: https://iscinumpy.dev/post/bound-version-constraints/

This change is required as a prerequisite of a similar change here, which in turn is required before I can upgrade rstcheck to a recent version here.

@sco1
Copy link
Owner

sco1 commented May 3, 2023

Seems fine.

An aside, if you're going to continue to do more of these that use Poetry please be sure to try relocking before submitting the PR.

@sco1 sco1 merged commit d831807 into sco1:main May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants