Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support React 18 as a peer dependency #312

Merged
merged 6 commits into from
Apr 11, 2024
Merged

Support React 18 as a peer dependency #312

merged 6 commits into from
Apr 11, 2024

Commits on Apr 10, 2024

  1. Bump peer dependency for React 

    Based on #293,
it appears this package works fine with React 18
    @fongandrew
    fongandrew committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    5912d85 View commit details
    Browse the repository at this point in the history

  2. Upgrade build packages 

    This resolves a whole bunch of warnings and build issues
from using out of date packages. Became sort of necessary
when we couldn't npm install anymore because our
out-of-date node-sass version demanded Python v2.
    @fongandrew
    fongandrew committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    9e9938b View commit details
    Browse the repository at this point in the history

  3. Fix tests 

    Fix some test failures that surfaced with newest version of Jest
    @fongandrew
    fongandrew committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    5dcedde View commit details
    Browse the repository at this point in the history

  4. Version bump 

    We've expanded our peer dependencies to allow React 18.
This isn't really a breaking change, but usage of this with
React >16 is under-tested. So we're going to do a major
version bump so that any projects that depend on this
package don't implicitly pick up this new version,
resolve to a different version of React, and suddenly find
old things not working.

Also, we revamped the build code and there are minor
compiler / TypeScript-ish changes there, so a little
extra caution feels warranted.
    @fongandrew
    fongandrew committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    0481cc7 View commit details
    Browse the repository at this point in the history

  5. Add some CI

    @fongandrew
    fongandrew committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    70051d2 View commit details
    Browse the repository at this point in the history

  6. Clean up broken badges

    @fongandrew
    fongandrew committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    1fd72cf View commit details
    Browse the repository at this point in the history