Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logger set to DEBUG #779

Merged
merged 4 commits into from
Jun 26, 2024
Merged

fix: logger set to DEBUG #779

merged 4 commits into from
Jun 26, 2024

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Jun 24, 2024

Causes too much logging in test output if user sets it higher than DEBUG. I think this was just to help the sdtputools backend.

@henryiii henryiii marked this pull request as draft June 24, 2024 22:30
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.96%. Comparing base (2708569) to head (9396d1f).
Report is 90 commits behind head on main.

Files with missing lines Patch % Lines
src/scikit_build_core/setuptools/build_cmake.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #779      +/-   ##
==========================================
- Coverage   81.96%   81.96%   -0.01%     
==========================================
  Files          68       68              
  Lines        3921     3925       +4     
==========================================
+ Hits         3214     3217       +3     
- Misses        707      708       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii marked this pull request as ready for review June 26, 2024 20:41
@henryiii henryiii merged commit 2de8c54 into main Jun 26, 2024
47 of 51 checks passed
@henryiii henryiii deleted the henryiii-patch-2 branch June 26, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant