Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: GetRequires args changed #699

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

henryiii
Copy link
Collaborator

This is needed for #637 (comment).

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii force-pushed the henryiii/refactor/GetRequires branch from 3d3b23e to 7e15390 Compare April 12, 2024 03:33
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 86.23%. Comparing base (5aea532) to head (7e15390).

Files Patch % Lines
src/scikit_build_core/setuptools/build_meta.py 0.00% 3 Missing ⚠️
src/scikit_build_core/builder/get_requires.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #699   +/-   ##
=======================================
  Coverage   86.23%   86.23%           
=======================================
  Files          64       64           
  Lines        3321     3321           
=======================================
  Hits         2864     2864           
  Misses        457      457           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henryiii henryiii merged commit 503c88d into main Apr 12, 2024
47 of 49 checks passed
@henryiii henryiii deleted the henryiii/refactor/GetRequires branch April 12, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant