-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: some cleanup from uv branch #686
Conversation
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #686 +/- ##
=======================================
Coverage 86.30% 86.30%
=======================================
Files 64 64
Lines 3315 3315
=======================================
Hits 2861 2861
Misses 454 454 ☔ View full report in Codecov by Sentry. |
@henryiii the |
We don't have to have it set so high, but updating to pybind11 2.12 is very important, otherwise packages will not be compatible with numpy 2.0, releasing soon. If you'd like a lower lower bound, feel free to adjust it (or tell me what would work). You could add it, I'd be in favor, though I'm not the only maintainer of pybind11. :) I am not sure about groups, they are separate projects but have a lot of synergy. |
Indeed the numpy 2.0 will be major release effort on Fedora, but I don't see it in the upcoming change proposals yet. But anyway for
Got it, I'll make a quick PR there. Indeed because of the synergy it would be nice to have them tested, and currently having them in the same copr repo is the only clean way to do it |
I'd like the bound because I'm hoping to test the minimums. Unfortunately, we'll probably have to list a different minimum version per Python version if we pick anything lower than 2.11 down to whatever you want as a minimum. (and Python 3.13 will require at least 2.12, if not higher). |
Pulling out a bit of cleanup, especially the better minimums.