Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: some cleanup from uv branch #686

Merged
merged 2 commits into from
Apr 5, 2024
Merged

chore: some cleanup from uv branch #686

merged 2 commits into from
Apr 5, 2024

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Apr 5, 2024

Pulling out a bit of cleanup, especially the better minimums.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.30%. Comparing base (32a1c5d) to head (eecb9c8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #686   +/-   ##
=======================================
  Coverage   86.30%   86.30%           
=======================================
  Files          64       64           
  Lines        3315     3315           
=======================================
  Hits         2861     2861           
  Misses        454      454           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pyproject.toml Outdated Show resolved Hide resolved
@henryiii henryiii merged commit 289383f into main Apr 5, 2024
37 of 53 checks passed
@henryiii henryiii deleted the henryiii/chore/clenaup branch April 5, 2024 17:40
@LecrisUT
Copy link
Collaborator

LecrisUT commented Apr 8, 2024

@henryiii the pybind11 lower pin seems to have made the rpm builds not compatible. There's also wheel for F38, but that can be skipped. I have pinged the maintainers for pybind11 update. But should I add packit automation to pybind11, and should it be under the scikit-build group (the difference is mostly that all builds in nightly/release are synchronized with the main/tag releases)

@henryiii
Copy link
Collaborator Author

henryiii commented Apr 8, 2024

We don't have to have it set so high, but updating to pybind11 2.12 is very important, otherwise packages will not be compatible with numpy 2.0, releasing soon. If you'd like a lower lower bound, feel free to adjust it (or tell me what would work).

You could add it, I'd be in favor, though I'm not the only maintainer of pybind11. :) I am not sure about groups, they are separate projects but have a lot of synergy.

@LecrisUT
Copy link
Collaborator

LecrisUT commented Apr 8, 2024

Indeed the numpy 2.0 will be major release effort on Fedora, but I don't see it in the upcoming change proposals yet. But anyway for test dependencies we should lower (or eliminate the bound if you are ok with that) until we find a combination that fails. Fedora packaging is not a good metric for that though, maybe we should try packaging at least for epel9 or start with epel10 (probably 1-2 years away).

You could add it, I'd be in favor, though I'm not the only maintainer of pybind11. :) I am not sure about groups, they are separate projects but have a lot of synergy.

Got it, I'll make a quick PR there. Indeed because of the synergy it would be nice to have them tested, and currently having them in the same copr repo is the only clean way to do it

@henryiii
Copy link
Collaborator Author

henryiii commented Apr 8, 2024

I'd like the bound because I'm hoping to test the minimums. Unfortunately, we'll probably have to list a different minimum version per Python version if we pick anything lower than 2.11 down to whatever you want as a minimum. (and Python 3.13 will require at least 2.12, if not higher).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants