Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use cmake -E capabilities instead of cmake --version #675

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

cmake -E capabilities produces a machine-readable version, and is the intended way for programs to get the CMake version.

KyleFromNVIDIA and others added 2 commits March 26, 2024 13:22
cmake -E capabilities produces a machine-readable version, and is
the intended way for programs to get the CMake version.
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.30%. Comparing base (3594f33) to head (d30360e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #675   +/-   ##
=======================================
  Coverage   86.30%   86.30%           
=======================================
  Files          64       64           
  Lines        3314     3315    +1     
=======================================
+ Hits         2860     2861    +1     
  Misses        454      454           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henryiii henryiii merged commit 715777d into scikit-build:main Mar 28, 2024
51 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants