Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow and mention ruff-formatter #299

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Conversation

henryiii
Copy link
Collaborator

Ruff-formatter seems to be ready. This doesn't change the default for the cookie yet, but mentions it in a tab, and allows it in sp-repo-review.

henryiii added a commit to scikit-build/scikit-build-core that referenced this pull request Oct 25, 2023
Some small things noticed while working on sp-repo-review.
scientific-python/cookie#299 and
scientific-python/cookie#300 and
scientific-python/repo-review#152.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Copy link
Member

@jarrodmillman jarrodmillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jarrodmillman
Copy link
Member

I'll leave the conflict for you to sort out. Thanks!!

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii
Copy link
Collaborator Author

Thanks! Charlie has already pointed me to that discussion. ;) I think if we can clearly describe what we want, then ruff-format (and maybe even black, I've seen a similar offer from them) will try to implement it.

@henryiii henryiii merged commit e03df78 into main Oct 27, 2023
25 checks passed
@henryiii henryiii deleted the henryiii/feat/rufffmt branch October 27, 2023 18:17
henryiii added a commit to scikit-hep/hist that referenced this pull request Nov 17, 2023
See scientific-python/cookie#299. Waiting on
astral-sh/ruff#8254.

---------

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants