Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON output with new --json/-J option #141

Closed
wants to merge 1 commit into from

Conversation

jasoncdavis
Copy link

Added support for a -J output flag to report ping results in JSON records - this is more desirable for programmatic consumption of the fping data

Added support for a -J output flag to report ping results in JSON records - this is more desirable for programmatic consumption of the fping data
@jasoncdavis
Copy link
Author

Added support for a -J output flag to report ping results in JSON records - this is more desirable for programmatic consumption of the fping data

@jasoncdavis jasoncdavis reopened this Nov 26, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.3%) to 78.402% when pulling cb09613 on jasoncdavis:master into f9e1964 on schweikert:master.

@schweikert schweikert changed the title Update fping.c Add JSON output with new --json/-J option Dec 2, 2018
@schweikert
Copy link
Owner

Thanks for your contribution! There are some changes that I would do before integrating it:

  • Call the option --json, instead of --JSON for consistency with the other options
  • Use standard output for the JSON output when in JSON mode, and stderr for everything else (as it should be also for the non-json mode, but we can't fix it there anymore)
  • Add some tests for this

@schweikert
Copy link
Owner

Continued in #160

@schweikert schweikert closed this Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants