Let Shapes and SlidePlaceholders fulfill the Mapping interface #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both are essentially mappings and define the minimal interface for `collections.abc.Mapping` (https://docs.python.org/3/library/collections.abc.html#collections-abstract-base-classes). By inheriting from `Mapping` we mix in the full mapping behavior, .e.g. `.get()` and `.key()` methods. This is to make these collections feel more pythonic. Additionally, it's a real usability improvement: e.g. for `SlidePlaceholders` one cannot guess the valid keys, which makes `placeholders[idx]` difficult to use. Having `placeholders.keys()` available makes inspection much easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both are essentially mappings and define the minimal interface
for
collections.abc.Mapping(https://docs.python.org/3/library/collections.abc.html#collections-abstract-base-classes),i.e.
__iter__,__getitem__and__len__.By inheriting from
Mappingwe mix in the full mapping behavior, .e.g..get()and
.key()methods. This is to make these collections feel more pythonic.Additionally, it's a real usability improvement: e.g. for
SlidePlaceholdersone cannot guess the valid keys, which makes
placeholders[idx]difficult to use.Having
placeholders.keys()available makes inspection much easier.