Feature/wide template #783
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Presentation now has an optional keyword template with valid values of default and wide. Other options can be added later. Instead of checking for known options (default and wide), it checks for an existing path. If the path does not exist, the error informs the user that default and wide were options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR addresses issues raised in issue #723. Specifically, it adds the capability for a user to specify which
templateto use for a new Presentation. The key change was adding a keyword to the api and a new template for 16x9 ratio slides (aka wide). Thewide.pptxis made using Powerpoint from Office16.After the changes, I ran tox using py27 and py36 (not py38, but should have similar performance). All existing tests pass. I also did basic manual tests using
pptx.Presentation.templatestill makes the same file using thepptx/templates/default.pptx.template='default'still makes the same file using thepptx/templates/default.pptx.template='wide'now makes a 16x9 ratio format using thepptx/templates/wide.pptx.I did not modify the tests/test_api.py because I am not familiar with the approach using those types of fixtures. Ideally, an additional test version using the alternate template would be added.