Bug Fix: Solved bug where html string failed to be encoded #605
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error is in the following line where .decode() is called without using the named parameter eventual_encoding.
pptx/compat/python3.py:
Its because in the latest version of bs4, indent_level is the first parameter so when you do not mention the parameter name, the wrong parameter is set with 'utf-8'. which causes an error on line
indent_space = (' ' * (indent_level - 1))
.Check out the function definition and the line marked with the comment in
bs4/element.py:
So, I just modified the call to use the named parameter directly.